[BACK-2540] Print reports#43
Merged
Merged
Conversation
updates for consistency to use `require` rather than import
add 'post' report, include basic tests
PDF Generation
* test out JS module conversion * tests update for cjs and rename file type for consistency --------- Co-authored-by: Jamie <jamie.h.bate@gmail.com>
convert from CJS to ESM
Report class
Member
|
/deploy qa2 |
clintonium-119
requested changes
Aug 23, 2023
clintonium-119
left a comment
clintonium-119
left a comment
Member
There was a problem hiding this comment.
Amazing work on this. Just one small suggested change to one of the unit tests.
Co-authored-by: Clint Beacock <clint.beacock@gmail.com>
clintonium-119
previously approved these changes
Aug 23, 2023
clintonium-119
left a comment
clintonium-119
left a comment
Member
There was a problem hiding this comment.
LGTM. Great job on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow pdf reports to be created from backend
docs tidepool-org/TidepoolApi#77