Conversation
add missing public bindings init finalize raise open file limit cancel background work and the s3 object store connector factories both the positional and full config forms with a graceful error when the library is built without s3 support fix abi struct drift that caused out of bounds writes the config struct was missing finish compactions on close so the by value default config return overflowed and open read past the buffer the db stats struct was missing eight trailing write amplification counters so get db stats wrote sixty four bytes past the caller buffer and the cf stats struct was missing seven write amplification fields add the busy error code at minus fourteen and expose the new write amplification counters in both cf stats and db stats correct the max concurrent flushes test the engine default is now zero meaning use the internal default rather than greater than zero add eight tests covering all of the above forty nine passing and extend the lua reference docs with the new functions config flag stat fields and s3 connector usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add missing public bindings init finalize raise open file limit cancel background work and the s3 object store connector factories both the positional and full config forms with a graceful error when the library is built without s3 support
fix abi struct drift that caused out of bounds writes the config struct was missing finish compactions on close so the by value default config return overflowed and open read past the buffer the db stats struct was missing eight trailing write amplification counters so get db stats wrote sixty four bytes past the caller buffer and the cf stats struct was missing seven write amplification fields
add the busy error code at minus fourteen and expose the new write amplification counters in both cf stats and db stats
correct the max concurrent flushes test the engine default is now zero meaning use the internal default rather than greater than zero
add eight tests covering all of the above forty nine passing and extend the lua reference docs with the new functions config flag stat fields and s3 connector usage