feat(android): adding showcancel property#131
Open
akansha-maheshwari wants to merge 2 commits intotidev:masterfrom
Open
feat(android): adding showcancel property#131akansha-maheshwari wants to merge 2 commits intotidev:masterfrom
akansha-maheshwari wants to merge 2 commits intotidev:masterfrom
Conversation
akansha-maheshwari
requested review from
aakash-jain-axway,
garymathews and
jquick-axway
|
Contributor
|
@akansha-maheshwari-axway, the files under the following folders were not made by us.
We copied the above file trees from the open source "zxing" repo below. Note that this open source project does not offer an AAR which means its res files have to be copied over to our project. Also, not all of its source code is provided by the zxing JARs which is why we have to copy the open source project's Java source tree to this repo. This means the edits you are making to these folders may end up being lost the next time we update this module with the newest zxing changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/MOD-1867
Adding default-overlay.js file to show default cancel behavior.