fix(android): improve Window focus/blur events#14456
Draft
m1ga wants to merge 2 commits into
Draft
Conversation
Collaborator
|
How does iOS behave here, especially for alerts? IIRC, it also fires blur/focus events prior/after showing alerts. |
Contributor
Author
|
need to check that on iOS. Since an alert would fire a blur event on Android after that change it might be better to give it a different event name in case iOS doesn't do that. Otherwise it might fire |
Contributor
Author
|
running the example code with the current main (not using this PR) on iOS and Android:
so this PR will actually make Android behave the same way as iOS is doing right now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will fire blur/focus event when you drag down the statusbar on your phone.
Note: This will also fire when an alert is shown! That is currently not the case. So I'm not sure if we should use a different event for this as it may cause problems in existing apps.
I could change it to
windowblurandwindowfocusso you have a different event for these new blur/focus and it won't break any exisintblur/focususage on a window