cache duplicated preprocessor fits#958
Draft
simonpcouch wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #955. A proof of concept for cutting out duplicated preprocessor fits for iterative tuning approaches. A bit of a contrived example, but on
main:Created on 2024-11-01 with reprex v2.1.1
After this PR:
Created on 2024-11-01 with reprex v2.1.1
split_idanditer_msg_preprocessorenough to uniquely identify a unique preprocessor fit when tuning iteratively? 2) What are the implications with different types of parallelism? We haven't used theprogress_envso far for parallelized computations, yet, but also the fact thathas_cached_result()would only returnTRUEfor iterative searches might mean that the needed information is always available in the parent process.