do not use vec_slice() for the key before computing hash

teunbrand · teunbrand · commit aa363bce13ac · 2026-04-13T12:49:54.000+02:00
diff --git a/R/guide-.R b/R/guide-.R
@@ -284,7 +284,7 @@ Guide <- ggproto(
 
     if (is.numeric(breaks)) {
       range <- scale$continuous_range %||% scale$get_limits()
-      key <- vec_slice(key, is.finite(oob_censor_any(breaks, range)))
+      key <- key[is.finite(oob_censor_any(breaks, range)), , drop = FALSE]
     } else {
       key
     }
diff --git a/R/guide-bins.R b/R/guide-bins.R
@@ -181,7 +181,7 @@ GuideBins <- ggproto(
     }
 
     key$.label <- labels
-    key <- vec_slice(key, !is.na(oob_censor_any(key$.value)))
+    key <- key[!is.na(oob_censor_any(key$.value)), , drop = FALSE]
 
     return(key)
   },

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,7 @@ Guide <- ggproto(`
`284`	`284`
`285`	`285`	`if (is.numeric(breaks)) {`
`286`	`286`	`range <- scale$continuous_range %\|\|% scale$get_limits()`
`287`		`- key <- vec_slice(key, is.finite(oob_censor_any(breaks, range)))`
	`287`	`+ key <- key[is.finite(oob_censor_any(breaks, range)), , drop = FALSE]`
`288`	`288`	`} else {`
`289`	`289`	`key`
`290`	`290`	`}`
Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ GuideBins <- ggproto(`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`key$.label <- labels`
`184`		`- key <- vec_slice(key, !is.na(oob_censor_any(key$.value)))`
	`184`	`+ key <- key[!is.na(oob_censor_any(key$.value)), , drop = FALSE]`
`185`	`185`
`186`	`186`	`return(key)`
`187`	`187`	`},`