Skip to content

Commit 0782473

Browse files
authored
fix: resolve initialization error of FilterParams by default (#259)
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
1 parent ab32553 commit 0782473

2 files changed

Lines changed: 15 additions & 2 deletions

File tree

t4_devkit/filtering/parameter.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,10 @@ class FilterParams:
2828

2929
labels: Sequence[str | SemanticLabel] | None = field(
3030
default=None,
31-
validator=validators.deep_iterable(
32-
validators.or_(validators.instance_of(str), validators.instance_of(SemanticLabel))
31+
validator=validators.optional(
32+
validators.deep_iterable(
33+
validators.or_(validators.instance_of(str), validators.instance_of(SemanticLabel))
34+
)
3335
),
3436
)
3537
uuids: Sequence[str] | None = field(

tests/fitering/test_filter_compose.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,17 @@
44
from t4_devkit.schema import VisibilityLevel
55

66

7+
def test_composite_filter_with_default_params(dummy_box3ds, dummy_box2ds, dummy_tf_buffer):
8+
params = FilterParams()
9+
box_filter = BoxFilter(params, dummy_tf_buffer)
10+
11+
answer3d = box_filter(dummy_box3ds)
12+
answer2d = box_filter(dummy_box2ds)
13+
14+
assert len(answer3d) == len(dummy_box3ds)
15+
assert len(answer2d) == len(dummy_box2ds)
16+
17+
718
def test_composite_filter(dummy_box3ds, dummy_box2ds, dummy_tf_buffer) -> None:
819
"""Test `BoxFilter` compositing the box filters.
920

0 commit comments

Comments
 (0)