Skip to content

Commit 4c958d8

Browse files
committed
refactor: remove lidarseg command from t4viz
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
1 parent 4c87c7a commit 4c958d8

5 files changed

Lines changed: 0 additions & 130 deletions

File tree

docs/cli/t4viz.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -64,16 +64,6 @@ For options, run `t4viz pointcloud -h`.
6464
t4viz pointcloud <DATA_ROOT> [OPTIONS]
6565
```
6666

67-
### LiDAR Segmentation
68-
69-
This command performs the same behavior with [`Tier4.render_lidarseg(...)`](../tutorials/render.md#rendering-lidar-segmentation).
70-
71-
For options, run `t4viz lidarseg -h`.
72-
73-
```shell
74-
t4viz lidarseg <DATA_ROOT> [OPTIONS]
75-
```
76-
7767
### Future Trajectories
7868

7969
`scene` and `instance` commands support visualizing future trajectories for each object.

docs/tutorials/render.md

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -48,22 +48,6 @@ If you want to visualize annotation results, `Tier4` supports some rendering met
4848
```
4949
<!-- prettier-ignore-end -->
5050

51-
### LiDAR Segmentation
52-
53-
```python
54-
>>> t4.render_lidarseg()
55-
```
56-
57-
<!--![Render LiDAR Segmentation GIF](../assets/render_lidarseg.gif)-->
58-
59-
<!-- prettier-ignore-start -->
60-
!!! NOTE
61-
`render_lidarseg()` method requires `lidarseg` data as follows:
62-
63-
```shell
64-
```
65-
<!-- prettier-ignore-end -->
66-
6751
### Save Recording
6852

6953
You can save the rendering result as follows:

t4_devkit/cli/visualize.py

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -120,43 +120,6 @@ def pointcloud(
120120
t4.render_pointcloud(ignore_distortion=ignore_distortion, save_dir=output)
121121

122122

123-
@cli.command("lidarseg", help="Visualize LiDAR segmentation pointcloud.")
124-
def lidarseg(
125-
data_root: Annotated[str, typer.Argument(help="Root directory path to the dataset.")],
126-
revision: Annotated[
127-
str | None,
128-
typer.Option(
129-
...,
130-
"-rv",
131-
"--revision",
132-
help="Specify if you want to load the specific version.",
133-
),
134-
] = None,
135-
ignore_distortion: Annotated[
136-
bool,
137-
typer.Option(
138-
...,
139-
"-ig",
140-
"--ignore-distortion",
141-
help="Indicates whether to ignore camera distortion",
142-
),
143-
] = True,
144-
output: Annotated[
145-
str | None,
146-
typer.Option(
147-
...,
148-
"-o",
149-
"--output",
150-
help="Output directory to save recorded .rrd file.",
151-
),
152-
] = None,
153-
) -> None:
154-
_create_dir(output)
155-
156-
t4 = Tier4(data_root, revision=revision, verbose=False)
157-
t4.render_lidarseg(ignore_distortion=ignore_distortion, save_dir=output)
158-
159-
160123
def _create_dir(dir_path: str | None) -> None:
161124
"""Create a directory with the specified path.
162125

t4_devkit/helper/rendering.py

Lines changed: 0 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -343,53 +343,6 @@ def render_pointcloud(
343343
),
344344
)
345345

346-
def render_lidarseg(
347-
self,
348-
*,
349-
max_time_seconds: float = np.inf,
350-
ignore_distortion: bool = True,
351-
save_dir: str | None = None,
352-
) -> None:
353-
"""Render lidar segmentation.
354-
355-
Args:
356-
max_time_seconds (float, optional): Max time length to be rendered [s].
357-
ignore_distortion (bool, optional): Whether to ignore distortion parameters.
358-
save_dir (str | None, optional): Directory path to save the recording.
359-
Viewer will be spawned if it is None, otherwise not.
360-
"""
361-
if self._sample_data_to_lidarseg_filename is None:
362-
return
363-
364-
app_id = f"lidarseg@{self._t4.dataset_id}"
365-
viewer = self._init_viewer(app_id, render_ann=True, save_dir=save_dir)
366-
367-
self._try_render_map(viewer)
368-
369-
# search first lidar sample data token
370-
first_lidar_token: str | None = None
371-
for sensor in self._t4.sensor:
372-
if sensor.modality != SensorModality.LIDAR:
373-
continue
374-
first_lidar_token = sensor.first_sd_token
375-
376-
if first_lidar_token is None:
377-
raise ValueError("There is no 3D pointcloud data.")
378-
379-
first_lidar_sample_data: Sample = self._t4.get("sample_data", first_lidar_token)
380-
max_timestamp_us = first_lidar_sample_data.timestamp + seconds2microseconds(
381-
max_time_seconds
382-
)
383-
384-
concurrent.futures.wait(
385-
self._render_lidar_and_ego(
386-
viewer=viewer,
387-
first_lidar_tokens=[first_lidar_token],
388-
max_timestamp_us=max_timestamp_us,
389-
color_mode=PointCloudColorMode.SEGMENTATION,
390-
)
391-
)
392-
393346
def _try_render_map(self, viewer: RerunViewer) -> None:
394347
lanelet_path = osp.join(self._t4.map_dir, "lanelet2_map.osm")
395348
if not osp.exists(lanelet_path):

t4_devkit/tier4.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -802,23 +802,3 @@ def render_pointcloud(
802802
ignore_distortion=ignore_distortion,
803803
save_dir=save_dir,
804804
)
805-
806-
def render_lidarseg(
807-
self,
808-
*,
809-
max_time_seconds: float = np.inf,
810-
ignore_distortion: bool = True,
811-
save_dir: str | None = None,
812-
) -> None:
813-
"""Render lidarseg on 3D view.
814-
815-
Args:
816-
max_time_seconds (float, optional): Max time length to be rendered [s].
817-
ignore_distortion (bool, optional): Whether to ignore distortion parameters.
818-
save_dir (str | None, optional): Directory path to save the recording.
819-
"""
820-
self._rendering_helper.render_lidarseg(
821-
max_time_seconds=max_time_seconds,
822-
ignore_distortion=ignore_distortion,
823-
save_dir=save_dir,
824-
)

0 commit comments

Comments
 (0)