Skip to content

Commit 72683e6

Browse files
authored
refactor: declare rule-id as class variable (#220)
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
1 parent dfd260f commit 72683e6

54 files changed

Lines changed: 116 additions & 66 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

t4_devkit/sanity/checker.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,11 @@ def is_error(self) -> bool:
3535
class Checker(ABC):
3636
"""Base class for sanity checkers."""
3737

38+
id: RuleID
3839
name: RuleName
3940
description: str
4041
severity: Severity
4142

42-
def __init__(self, id: RuleID) -> None:
43-
self.id = id
44-
4543
def __call__(self, context: SanityContext) -> Report:
4644
match self.can_skip(context):
4745
case Some(skip):

t4_devkit/sanity/format/base.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ class FieldTypeChecker(Checker):
2020
"""Base class for format checkers.
2121
2222
Attributes:
23+
id (RuleID): The ID of the rule.
2324
name (RuleName): The name of the rule.
2425
severity (Severity): The severity of the rule.
2526
description (str): The description of the rule.

t4_devkit/sanity/format/fmt001.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
__all__ = ["FMT001"]
1010

1111

12-
@CHECKERS.register(RuleID("FMT001"))
12+
@CHECKERS.register()
1313
class FMT001(FieldTypeChecker):
1414
"""A checker of FMT001."""
1515

16+
id = RuleID("FMT001")
1617
name = RuleName("attribute-field")
1718
severity = Severity.ERROR
1819
description = "All types of 'Attribute' fields are valid."

t4_devkit/sanity/format/fmt002.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
__all__ = ["FMT002"]
1010

1111

12-
@CHECKERS.register(RuleID("FMT002"))
12+
@CHECKERS.register()
1313
class FMT002(FieldTypeChecker):
1414
"""A checker of FMT002."""
1515

16+
id = RuleID("FMT002")
1617
name = RuleName("calibrated-sensor-field")
1718
severity = Severity.ERROR
1819
description = "All types of 'CalibratedSensor' fields are valid."

t4_devkit/sanity/format/fmt003.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
__all__ = ["FMT003"]
1010

1111

12-
@CHECKERS.register(RuleID("FMT003"))
12+
@CHECKERS.register()
1313
class FMT003(FieldTypeChecker):
1414
"""A checker of FMT003."""
1515

16+
id = RuleID("FMT003")
1617
name = RuleName("category-field")
1718
severity = Severity.ERROR
1819
description = "All types of 'Category' fields are valid."

t4_devkit/sanity/format/fmt004.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
__all__ = ["FMT004"]
1010

1111

12-
@CHECKERS.register(RuleID("FMT004"))
12+
@CHECKERS.register()
1313
class FMT004(FieldTypeChecker):
1414
"""A checker of FMT004."""
1515

16+
id = RuleID("FMT004")
1617
name = RuleName("ego-pose-field")
1718
severity = Severity.ERROR
1819
description = "All types of 'EgoPose' fields are valid."

t4_devkit/sanity/format/fmt005.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
__all__ = ["FMT005"]
1010

1111

12-
@CHECKERS.register(RuleID("FMT005"))
12+
@CHECKERS.register()
1313
class FMT005(FieldTypeChecker):
1414
"""A checker of FMT005."""
1515

16+
id = RuleID("FMT005")
1617
name = RuleName("instance-field")
1718
severity = Severity.ERROR
1819
description = "All types of 'Instance' fields are valid."

t4_devkit/sanity/format/fmt006.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
__all__ = ["FMT006"]
1010

1111

12-
@CHECKERS.register(RuleID("FMT006"))
12+
@CHECKERS.register()
1313
class FMT006(FieldTypeChecker):
1414
"""A checker of FMT006."""
1515

16+
id = RuleID("FMT006")
1617
name = RuleName("log-field")
1718
severity = Severity.ERROR
1819
description = "All types of 'Log' fields are valid."

t4_devkit/sanity/format/fmt007.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
__all__ = ["FMT007"]
1010

1111

12-
@CHECKERS.register(RuleID("FMT007"))
12+
@CHECKERS.register()
1313
class FMT007(FieldTypeChecker):
1414
"""A checker of FMT007."""
1515

16+
id = RuleID("FMT007")
1617
name = RuleName("map-field")
1718
severity = Severity.ERROR
1819
description = "All types of 'Map' fields are valid."

t4_devkit/sanity/format/fmt008.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
__all__ = ["FMT008"]
1010

1111

12-
@CHECKERS.register(RuleID("FMT008"))
12+
@CHECKERS.register()
1313
class FMT008(FieldTypeChecker):
1414
"""A checker of FMT008."""
1515

16+
id = RuleID("FMT008")
1617
name = RuleName("sample-field")
1718
severity = Severity.ERROR
1819
description = "All types of 'Sample' fields are valid."

0 commit comments

Comments
 (0)