Skip to content

Commit 7b69562

Browse files
committed
refactor: use list comprehension
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
1 parent 2568a38 commit 7b69562

1 file changed

Lines changed: 30 additions & 22 deletions

File tree

t4_devkit/helper/rendering.py

Lines changed: 30 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -113,17 +113,21 @@ def render_scene(
113113
Viewer will be spawned if it is None, otherwise not.
114114
"""
115115
# search first sample data tokens
116-
first_lidar_tokens: list[str] = []
117-
first_radar_tokens: list[str] = []
118-
first_camera_tokens: list[str] = []
119-
for sensor in self._t4.sensor:
120-
sd_token = sensor.first_sd_token
121-
if sensor.modality == SensorModality.LIDAR:
122-
first_lidar_tokens.append(sd_token)
123-
elif sensor.modality == SensorModality.RADAR:
124-
first_radar_tokens.append(sd_token)
125-
elif sensor.modality == SensorModality.CAMERA:
126-
first_camera_tokens.append(sd_token)
116+
first_lidar_tokens: list[str] = [
117+
sensor.first_sd_token
118+
for sensor in self._t4.sensor
119+
if sensor.modality == SensorModality.LIDAR
120+
]
121+
first_radar_tokens: list[str] = [
122+
sensor.first_sd_token
123+
for sensor in self._t4.sensor
124+
if sensor.modality == SensorModality.RADAR
125+
]
126+
first_camera_tokens: list[str] = [
127+
sensor.first_sd_token
128+
for sensor in self._t4.sensor
129+
if sensor.modality == SensorModality.CAMERA
130+
]
127131

128132
render3d = len(first_lidar_tokens) > 0 or len(first_radar_tokens) > 0
129133
render2d = len(first_camera_tokens) > 0
@@ -212,17 +216,21 @@ def render_instance(
212216
max_timestamp_us = last_sample.timestamp
213217

214218
# search first sample data tokens
215-
first_lidar_tokens: list[str] = []
216-
first_radar_tokens: list[str] = []
217-
first_camera_tokens: list[str] = []
218-
for sensor in self._t4.sensor:
219-
sd_token = sensor.first_sd_token
220-
if sensor.modality == SensorModality.LIDAR:
221-
first_lidar_tokens.append(sd_token)
222-
elif sensor.modality == SensorModality.RADAR:
223-
first_radar_tokens.append(sd_token)
224-
elif sensor.modality == SensorModality.CAMERA:
225-
first_camera_tokens.append(sd_token)
219+
first_lidar_tokens: list[str] = [
220+
sensor.first_sd_token
221+
for sensor in self._t4.sensor
222+
if sensor.modality == SensorModality.LIDAR
223+
]
224+
first_radar_tokens: list[str] = [
225+
sensor.first_sd_token
226+
for sensor in self._t4.sensor
227+
if sensor.modality == SensorModality.RADAR
228+
]
229+
first_camera_tokens: list[str] = [
230+
sensor.first_sd_token
231+
for sensor in self._t4.sensor
232+
if sensor.modality == SensorModality.CAMERA
233+
]
226234

227235
render3d = len(first_lidar_tokens) > 0 or len(first_radar_tokens) > 0
228236
render2d = len(first_camera_tokens) > 0

0 commit comments

Comments
 (0)