fix: Fix an error when converting null masks in object_ann and surface_ann#143
Conversation
|
Hi @ktro2828 It seems that I dont have the permission to add reviewers in this PR. Would you mind taking a look? Thanks |
ktro2828
left a comment
There was a problem hiding this comment.
Thank you for catching!
Could you also update SurfaceAnn.bbox for the case of mask=None?
t4-devkit/t4_devkit/schema/tables/surface_ann.py
Lines 48 to 59 in cde769f
def bbox(...) -> RoiLike | None:
if mask is None:
return None
# ...|
@KSeangTan Also, do you know the database version of the corresponding dataset? Is the latest or old one? |
|
Hi @ktro2828 It's the older database, one of the example is |
There was a problem hiding this comment.
LGTM
@KSeangTan Could fix CI failure in pre-commit?
|
Hi @ktro2828 |
The validator will fail when our mask value is
null, this PR fixes that by allowing passingNonevalueinmask`.