From 3e02791d2e72af39d612711afe927d030d12a421 Mon Sep 17 00:00:00 2001 From: ktro2828 Date: Fri, 4 Jul 2025 13:29:54 +0900 Subject: [PATCH 1/3] style: fix wrong type hint Signed-off-by: ktro2828 --- t4_devkit/cli/sanity.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/t4_devkit/cli/sanity.py b/t4_devkit/cli/sanity.py index 14aba58..b83e064 100644 --- a/t4_devkit/cli/sanity.py +++ b/t4_devkit/cli/sanity.py @@ -26,9 +26,7 @@ def _run_sanity_check( ) -> list[DBException]: exceptions: list[DBException] = [] - db_dirs: list[Path] = Path(db_parent).glob("*") - - for db_root in tqdm(db_dirs, desc=">>>Sanity checking..."): + for db_root in tqdm(Path(db_parent).glob("*"), desc=">>>Sanity checking..."): result = sanity_check(db_root, revision=revision, include_warning=include_warning) if result: exceptions.append(result) From c90884061550788d7207484e59fcd4c846b8b065 Mon Sep 17 00:00:00 2001 From: ktro2828 Date: Fri, 4 Jul 2025 13:54:25 +0900 Subject: [PATCH 2/3] style: rename variable Signed-off-by: ktro2828 --- t4_devkit/common/converter.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/t4_devkit/common/converter.py b/t4_devkit/common/converter.py index 8f74a38..e3c585f 100644 --- a/t4_devkit/common/converter.py +++ b/t4_devkit/common/converter.py @@ -11,17 +11,17 @@ __all__ = ["to_quaternion"] -def to_quaternion(value: ArrayLike | NDArray) -> Quaternion: +def to_quaternion(x: ArrayLike | NDArray) -> Quaternion: """Convert input rotation like array to `Quaternion`. Args: - value (ArrayLike | NDArray): Rotation matrix or quaternion. + x (ArrayLike | NDArray): Rotation matrix or quaternion. Returns: Quaternion: Converted instance. """ return ( - Quaternion(matrix=value) - if isinstance(value, np.ndarray) and value.ndim == 2 - else Quaternion(value) + Quaternion(matrix=x) + if isinstance(x, np.ndarray) and x.ndim == 2 + else Quaternion(x) ) From 0eed269bc7a085f66b5f8e9f945b5a0168300273 Mon Sep 17 00:00:00 2001 From: ktro2828 <60615504+ktro2828@users.noreply.github.com> Date: Fri, 4 Jul 2025 05:21:33 +0000 Subject: [PATCH 3/3] style(pre-commit): autofix --- t4_devkit/common/converter.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/t4_devkit/common/converter.py b/t4_devkit/common/converter.py index e3c585f..0254b9d 100644 --- a/t4_devkit/common/converter.py +++ b/t4_devkit/common/converter.py @@ -20,8 +20,4 @@ def to_quaternion(x: ArrayLike | NDArray) -> Quaternion: Returns: Quaternion: Converted instance. """ - return ( - Quaternion(matrix=x) - if isinstance(x, np.ndarray) and x.ndim == 2 - else Quaternion(x) - ) + return Quaternion(matrix=x) if isinstance(x, np.ndarray) and x.ndim == 2 else Quaternion(x)