Skip to content

style: fix invalid type hint #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktro2828 merged 3 commits into from
Jul 4, 2025
Merged

style: fix invalid type hint #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e02791
style: fix wrong type hint
ktro2828 Jul 4, 2025
c908840
style: rename variable
ktro2828 Jul 4, 2025
0eed269
style(pre-commit): autofix
ktro2828 Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions t4_devkit/cli/sanity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ def _run_sanity_check(
) -> list[DBException]:
exceptions: list[DBException] = []

db_dirs: list[Path] = Path(db_parent).glob("*")

for db_root in tqdm(db_dirs, desc=">>>Sanity checking..."):
for db_root in tqdm(Path(db_parent).glob("*"), desc=">>>Sanity checking..."):
result = sanity_check(db_root, revision=revision, include_warning=include_warning)
if result:
exceptions.append(result)
Expand Down
10 changes: 3 additions & 7 deletions t4_devkit/common/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,13 @@
__all__ = ["to_quaternion"]


def to_quaternion(value: ArrayLike | NDArray) -> Quaternion:
def to_quaternion(x: ArrayLike | NDArray) -> Quaternion:
"""Convert input rotation like array to `Quaternion`.

Args:
value (ArrayLike | NDArray): Rotation matrix or quaternion.
x (ArrayLike | NDArray): Rotation matrix or quaternion.

Returns:
Quaternion: Converted instance.
"""
return (
Quaternion(matrix=value)
if isinstance(value, np.ndarray) and value.ndim == 2
else Quaternion(value)
)
return Quaternion(matrix=x) if isinstance(x, np.ndarray) and x.ndim == 2 else Quaternion(x)