refactor: simplify token2idx creation with dict comprehension#168
Merged
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the token2idx creation logic by replacing a nested loop structure with a more concise nested dictionary comprehension. The change improves code readability while maintaining identical functionality for building a mapping from schema values to table tokens and their indices.
- Replaced nested for loops with a single nested dictionary comprehension
- Eliminated the need for a temporary variable and explicit dictionary initialization
- Maintained the same data structure and functionality
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR replaces nested loop with a more concise nested dictionary comprehension while maintaining the same functionality and improving readability.