Skip to content

feat: add support of rendering lanelet map#178

Merged
ktro2828 merged 9 commits into
mainfrom
feat/viewer/lanelet2
Aug 28, 2025
Merged

feat: add support of rendering lanelet map#178
ktro2828 merged 9 commits into
mainfrom
feat/viewer/lanelet2

Conversation

@ktro2828

Copy link
Copy Markdown
Collaborator

What

This PR adds new feature to render lanelet map on 3D space and street view.

To render lanelet map, ensure that your T4 dataset includes map/lanelet2_map.osm file.

On the street view, which is right side of panel, black lines represents road borders of lanelet.

We can render lanelet map by using CLI, or RerunViewer directly:

# CLI
t4viz scene <DATASET_PATH>
Screenshot from 2025-08-28 18-31-30
# RerunViewer

>>> from t4_devkit.viewer import RerunViewer
>>> viewer = RerunViewer(app_id="foo")
>>> viewer.render_map(<OSM_FILEPATH>)
render_map

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Copilot AI review requested due to automatic review settings August 28, 2025 09:48
@github-actions github-actions Bot added documentation Improvements or additions to documentation new-feature New feature or request labels Aug 28, 2025
@github-actions

github-actions Bot commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

☂️ Python Coverage

current status: ❌

Overall Coverage

Lines Covered Coverage Threshold Status
2651 1834 69% 50% 🟢

New Files

File Coverage Status
t4_devkit/lanelet/init.py 100% 🟢
t4_devkit/lanelet/parser.py 77% 🔴
t4_devkit/viewer/lanelet.py 59% 🔴
TOTAL 79% 🔴

Modified Files

File Coverage Status
t4_devkit/helper/rendering.py 13% 🔴
t4_devkit/tier4.py 18% 🔴
t4_devkit/viewer/viewer.py 84% 🟢
TOTAL 39% 🔴

updated for commit: add5ea4 by action🐍

This comment was marked as outdated.

@github-actions github-actions Bot added the ci Continuous Integration (CI) processes and testing label Aug 28, 2025
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 force-pushed the feat/viewer/lanelet2 branch from b3756c6 to 34c7850 Compare August 28, 2025 10:03
@ktro2828 ktro2828 requested a review from Copilot August 28, 2025 10:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds lanelet map rendering functionality to the T4 viewer, enabling visualization of vector maps in both 3D space and street view. The implementation introduces a new LaneletParser for processing OSM files and integrates lanelet rendering into the existing viewer infrastructure.

  • Adds LaneletParser to parse OSM XML files containing lanelet map data
  • Implements lanelet rendering functions for visualizing roads, traffic elements, and road borders
  • Integrates automatic map rendering into scene visualization workflows

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
t4_devkit/lanelet/parser.py Core parser for OSM XML files with nodes, ways, and relations
t4_devkit/viewer/lanelet.py Rendering functions for lanelet elements in 3D and geographic views
t4_devkit/viewer/viewer.py Integration of map rendering into RerunViewer
t4_devkit/helper/rendering.py Automatic map rendering in scene visualization methods
t4_devkit/tier4.py Property additions for map and annotation directory paths
tests/ Test files and sample OSM data for validation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread t4_devkit/viewer/lanelet.py
Comment thread t4_devkit/helper/rendering.py Outdated
Comment thread t4_devkit/viewer/lanelet.py
@ktro2828 ktro2828 changed the title Feat/viewer/lanelet2 feat: add support of rendering lanelet map Aug 28, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ktro2828 ktro2828 merged commit 8c33119 into main Aug 28, 2025
4 of 5 checks passed
@ktro2828 ktro2828 deleted the feat/viewer/lanelet2 branch August 28, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration (CI) processes and testing documentation Improvements or additions to documentation new-feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants