feat: add support of rendering lanelet map#178
Merged
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Contributor
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
b3756c6 to
34c7850
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds lanelet map rendering functionality to the T4 viewer, enabling visualization of vector maps in both 3D space and street view. The implementation introduces a new LaneletParser for processing OSM files and integrates lanelet rendering into the existing viewer infrastructure.
- Adds LaneletParser to parse OSM XML files containing lanelet map data
- Implements lanelet rendering functions for visualizing roads, traffic elements, and road borders
- Integrates automatic map rendering into scene visualization workflows
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
t4_devkit/lanelet/parser.py |
Core parser for OSM XML files with nodes, ways, and relations |
t4_devkit/viewer/lanelet.py |
Rendering functions for lanelet elements in 3D and geographic views |
t4_devkit/viewer/viewer.py |
Integration of map rendering into RerunViewer |
t4_devkit/helper/rendering.py |
Automatic map rendering in scene visualization methods |
t4_devkit/tier4.py |
Property additions for map and annotation directory paths |
tests/ |
Test files and sample OSM data for validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds new feature to render lanelet map on 3D space and street view.
To render lanelet map, ensure that your T4 dataset includes
map/lanelet2_map.osmfile.On the street view, which is right side of panel, black lines represents road borders of lanelet.
We can render lanelet map by using CLI, or
RerunViewerdirectly: