refactor: define the method to load tables as function#180
Merged
Conversation
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
ktro2828
force-pushed
the
refactor/load-table
branch
from
13c1454 to
e7147d8
Compare
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
ktro2828
force-pushed
the
refactor/load-table
branch
from
e7147d8 to
467cd04
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the table loading mechanism by extracting the private __load_table__ method from the Tier4 class into a standalone load_table function. This change improves code organization by making the table loading functionality accessible outside the class context.
- Converts a private class method to a public module-level function
- Updates all table loading calls in the
Tier4constructor to use the new function - Adds the new function to the module's
__all__export list
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR removes
Tier4.__load_table__(...)method and define as function calledload_table(...).