Skip to content

test: add sample t4 dataset for unit test#183

Merged
ktro2828 merged 3 commits into
mainfrom
test/sample-t4dataset
Sep 1, 2025
Merged

test: add sample t4 dataset for unit test#183
ktro2828 merged 3 commits into
mainfrom
test/sample-t4dataset

Conversation

@ktro2828

@ktro2828 ktro2828 commented Aug 29, 2025

Copy link
Copy Markdown
Collaborator

What

This pull request introduces a comprehensive set of sample annotation files for a minimal T4 dataset, which will be useful for unit testing and development. It also updates the import of Quaternion in the converter module to use the project's own type definition. The most important changes are grouped below:

Dataset Sample Annotation Additions

  • Added complete sample annotation files in tests/sample/annotation/ covering attributes, categories, instances, scenes, logs, maps, sensors, calibrated sensors, ego poses, samples, sample data, sample annotations, object annotations, and surface annotations. These files provide a minimal but realistic dataset for unit testing and integration. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]

Codebase Maintenance

  • Updated the import for Quaternion in t4_devkit/common/converter.py to use the local type definition from t4_devkit.typing instead of the external pyquaternion library, improving code consistency and maintainability.

Copilot AI review requested due to automatic review settings August 29, 2025 11:44
@github-actions github-actions Bot added the ci Continuous Integration (CI) processes and testing label Aug 29, 2025
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 force-pushed the test/sample-t4dataset branch from 3bf6242 to 11102e6 Compare August 29, 2025 11:46
@github-actions

github-actions Bot commented Aug 29, 2025

Copy link
Copy Markdown
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2649 2017 76% 50% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
t4_devkit/common/converter.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 5af07cb by action🐍

@ktro2828 ktro2828 linked an issue Aug 29, 2025 that may be closed by this pull request
2 tasks

This comment was marked as outdated.

@ktro2828 ktro2828 requested a review from Copilot August 31, 2025 14:51

This comment was marked as outdated.

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 requested a review from Copilot September 1, 2025 02:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces a comprehensive sample T4 dataset for unit testing along with a minor import update. The sample dataset provides a minimal but complete T4 dataset structure with 1 scene, 3 samples, 9 sample data entries, and associated annotations covering all major schema types.

Key changes include:

  • Addition of complete sample annotation files covering all T4 schema types (attributes, categories, instances, scenes, logs, maps, sensors, calibrated sensors, ego poses, samples, sample data, sample annotations, object annotations, and surface annotations)
  • Comprehensive integration test suite using the real sample dataset to validate end-to-end functionality
  • Import update to use local Quaternion type definition instead of external library

Reviewed Changes

Copilot reviewed 19 out of 28 changed files in this pull request and generated 4 comments.

File Description
tests/test_tier4.py Comprehensive integration tests using sample T4 dataset for end-to-end validation
tests/sample/status.json Dataset metadata file with statistics and sensor configuration
tests/sample/annotation/*.json Complete set of annotation files providing minimal T4 dataset structure
t4_devkit/common/converter.py Updated Quaternion import to use local type definition
Comments suppressed due to low confidence (2)

tests/sample/annotation/surface_ann.json:1

  • These extremely long base64-encoded mask strings make the JSON files difficult to read and maintain. Consider using shorter placeholder masks or storing these in separate binary files for better maintainability of the test data.
[

tests/sample/annotation/surface_ann.json:1

  • These extremely long base64-encoded mask strings make the JSON files difficult to read and maintain. Consider using shorter placeholder masks or storing these in separate binary files for better maintainability of the test data.
[

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/sample/annotation/object_ann.json
Comment thread tests/sample/annotation/object_ann.json
Comment thread tests/sample/annotation/object_ann.json
Comment thread tests/sample/annotation/object_ann.json
@ktro2828 ktro2828 merged commit 2b1793e into main Sep 1, 2025
5 checks passed
@ktro2828 ktro2828 deleted the test/sample-t4dataset branch September 1, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration (CI) processes and testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI]: add integration test with a sample T4 dataset

2 participants