test: add sample t4 dataset for unit test#183
Merged
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
3bf6242 to
11102e6
Compare
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
2 tasks
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a comprehensive sample T4 dataset for unit testing along with a minor import update. The sample dataset provides a minimal but complete T4 dataset structure with 1 scene, 3 samples, 9 sample data entries, and associated annotations covering all major schema types.
Key changes include:
- Addition of complete sample annotation files covering all T4 schema types (attributes, categories, instances, scenes, logs, maps, sensors, calibrated sensors, ego poses, samples, sample data, sample annotations, object annotations, and surface annotations)
- Comprehensive integration test suite using the real sample dataset to validate end-to-end functionality
- Import update to use local Quaternion type definition instead of external library
Reviewed Changes
Copilot reviewed 19 out of 28 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/test_tier4.py | Comprehensive integration tests using sample T4 dataset for end-to-end validation |
| tests/sample/status.json | Dataset metadata file with statistics and sensor configuration |
| tests/sample/annotation/*.json | Complete set of annotation files providing minimal T4 dataset structure |
| t4_devkit/common/converter.py | Updated Quaternion import to use local type definition |
Comments suppressed due to low confidence (2)
tests/sample/annotation/surface_ann.json:1
- These extremely long base64-encoded mask strings make the JSON files difficult to read and maintain. Consider using shorter placeholder masks or storing these in separate binary files for better maintainability of the test data.
[
tests/sample/annotation/surface_ann.json:1
- These extremely long base64-encoded mask strings make the JSON files difficult to read and maintain. Consider using shorter placeholder masks or storing these in separate binary files for better maintainability of the test data.
[
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This pull request introduces a comprehensive set of sample annotation files for a minimal T4 dataset, which will be useful for unit testing and development. It also updates the import of
Quaternionin the converter module to use the project's own type definition. The most important changes are grouped below:Dataset Sample Annotation Additions
tests/sample/annotation/covering attributes, categories, instances, scenes, logs, maps, sensors, calibrated sensors, ego poses, samples, sample data, sample annotations, object annotations, and surface annotations. These files provide a minimal but realistic dataset for unit testing and integration. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Codebase Maintenance
Quaternionint4_devkit/common/converter.pyto use the local type definition fromt4_devkit.typinginstead of the externalpyquaternionlibrary, improving code consistency and maintainability.