feat: add new schema for lidarseg#184
Merged
Merged
Conversation
Contributor
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
8e35104 to
c4c6397
Compare
c4c6397 to
fc313d1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for LiDAR point cloud segmentation data to the schema system by introducing the new LidarSeg schema. The changes enable handling of lidar segmentation annotations as an optional component of the dataset structure.
- Adds
LidarSegschema class with token, filename, and sample_data_token fields - Registers the new schema as optional in the system with proper enum and helper method updates
- Integrates LidarSeg into the main data loading pipeline through the Tier4 class
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| t4_devkit/schema/name.py | Adds LIDARSEG enum value and marks it as optional |
| t4_devkit/schema/tables/lidarseg.py | Implements the LidarSeg dataclass schema |
| t4_devkit/schema/tables/init.py | Adds lidarseg import to module exports |
| t4_devkit/tier4.py | Integrates LidarSeg into main data container |
| tests/schema/conftest.py | Adds test fixtures for lidarseg testing |
| tests/schema/tables/test_lidarseg_table.py | Implements unit tests for LidarSeg schema |
| tests/schema/test_schema_builder.py | Adds test for LidarSeg schema building |
| tests/schema/test_schema_name.py | Updates schema name tests to include lidarseg |
| docs/schema/table.md | Documents the new LidarSeg table structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
Author
TODO
|
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
fc313d1 to
ceb9f8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This pull request adds support for lidar point cloud segmentation data to the schema system. The main changes introduce the new
LidarSegschema, update the schema registry and builder logic, and add corresponding tests and fixtures to ensure proper integration and functionality.Schema System Enhancements:
SchemaName.LIDARSEGenum value and marked it as optional in the schema definition and helper methodis_optional. (t4_devkit/schema/name.py) [1] [2] [3]LidarSegdataclass schema for representing lidar point cloud segmentation data, and registered it in the schema registry. (t4_devkit/schema/tables/lidarseg.py)lidarseg. (t4_devkit/schema/tables/__init__.py)Integration with Main Data Structures:
LidarSeginto the main annotation loading logic by updating the data container and loader to supportlidarsegrecords. (t4_devkit/tier4.py) [1] [2]Testing and Fixtures:
lidarsegrecords, including JSON serialization and file handling. (tests/schema/conftest.py)LidarSegschema, including loading from JSON and dict, serialization, and token generation. (tests/schema/tables/test_lidarseg_table.py)LidarSegschema using the schema builder. (tests/schema/test_schema_builder.py)lidarsegtype and its optional status. (tests/schema/test_schema_name.py)