Skip to content

feat: add new schema for lidarseg#184

Merged
ktro2828 merged 3 commits into
mainfrom
feat/schema/lidarseg
Oct 2, 2025
Merged

feat: add new schema for lidarseg#184
ktro2828 merged 3 commits into
mainfrom
feat/schema/lidarseg

Conversation

@ktro2828

@ktro2828 ktro2828 commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator

What

This pull request adds support for lidar point cloud segmentation data to the schema system. The main changes introduce the new LidarSeg schema, update the schema registry and builder logic, and add corresponding tests and fixtures to ensure proper integration and functionality.

Schema System Enhancements:

  • Added a new SchemaName.LIDARSEG enum value and marked it as optional in the schema definition and helper method is_optional. (t4_devkit/schema/name.py) [1] [2] [3]
  • Implemented the LidarSeg dataclass schema for representing lidar point cloud segmentation data, and registered it in the schema registry. (t4_devkit/schema/tables/lidarseg.py)
  • Updated schema imports to include lidarseg. (t4_devkit/schema/tables/__init__.py)

Integration with Main Data Structures:

  • Integrated LidarSeg into the main annotation loading logic by updating the data container and loader to support lidarseg records. (t4_devkit/tier4.py) [1] [2]

Testing and Fixtures:

  • Added test fixtures and helper functions for dummy lidarseg records, including JSON serialization and file handling. (tests/schema/conftest.py)
  • Added unit tests for the LidarSeg schema, including loading from JSON and dict, serialization, and token generation. (tests/schema/tables/test_lidarseg_table.py)
  • Added a test for building a LidarSeg schema using the schema builder. (tests/schema/test_schema_builder.py)
  • Updated schema name tests to include the new lidarseg type and its optional status. (tests/schema/test_schema_name.py)

@github-actions github-actions Bot added ci Continuous Integration (CI) processes and testing new-feature New feature or request labels Sep 1, 2025
@github-actions

github-actions Bot commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2737 2103 77% 50% 🟢

New Files

File Coverage Status
t4_devkit/schema/tables/lidarseg.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
t4_devkit/schema/name.py 100% 🟢
t4_devkit/schema/tables/init.py 100% 🟢
t4_devkit/tier4.py 81% 🟢
TOTAL 94% 🟢

updated for commit: ceb9f8f by action🐍

@tier4 tier4 deleted a comment from github-actions Bot Sep 1, 2025
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 1, 2025
@ktro2828 ktro2828 force-pushed the feat/schema/lidarseg branch from 8e35104 to c4c6397 Compare September 2, 2025 04:44
@ktro2828 ktro2828 force-pushed the feat/schema/lidarseg branch from c4c6397 to fc313d1 Compare September 10, 2025 15:25
@ktro2828 ktro2828 marked this pull request as ready for review September 10, 2025 15:27
Copilot AI review requested due to automatic review settings September 10, 2025 15:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for LiDAR point cloud segmentation data to the schema system by introducing the new LidarSeg schema. The changes enable handling of lidar segmentation annotations as an optional component of the dataset structure.

  • Adds LidarSeg schema class with token, filename, and sample_data_token fields
  • Registers the new schema as optional in the system with proper enum and helper method updates
  • Integrates LidarSeg into the main data loading pipeline through the Tier4 class

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
t4_devkit/schema/name.py Adds LIDARSEG enum value and marks it as optional
t4_devkit/schema/tables/lidarseg.py Implements the LidarSeg dataclass schema
t4_devkit/schema/tables/init.py Adds lidarseg import to module exports
t4_devkit/tier4.py Integrates LidarSeg into main data container
tests/schema/conftest.py Adds test fixtures for lidarseg testing
tests/schema/tables/test_lidarseg_table.py Implements unit tests for LidarSeg schema
tests/schema/test_schema_builder.py Adds test for LidarSeg schema building
tests/schema/test_schema_name.py Updates schema name tests to include lidarseg
docs/schema/table.md Documents the new LidarSeg table structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ktro2828

ktro2828 commented Sep 11, 2025

Copy link
Copy Markdown
Collaborator Author

TODO

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 force-pushed the feat/schema/lidarseg branch from fc313d1 to ceb9f8f Compare October 2, 2025 08:36
@ktro2828 ktro2828 merged commit 1ba491c into main Oct 2, 2025
4 of 5 checks passed
@ktro2828 ktro2828 deleted the feat/schema/lidarseg branch October 2, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration (CI) processes and testing documentation Improvements or additions to documentation new-feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants