fix: update to only render crosswalk polygons#186
Merged
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request modifies the render_lanelets function to exclusively render crosswalk lanelets, addressing visualization issues where crosswalk polygons were being overlapped by road lanelets. The change simplifies the rendering logic by filtering out all non-crosswalk lanelet subtypes at the entry point and removing conditional color/element type assignments.
- Adds filtering to only process lanelets with subtype "crosswalk"
- Removes conditional logic for different lanelet subtypes ("road", "shoulder")
- Updates function documentation to clarify the crosswalk-only behavior
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This pull request updates the
render_laneletsfunction int4_devkit/viewer/lanelet.pyto only render lanelets of subtype "crosswalk", simplifying both the filtering logic and rendering behavior. The changes remove support for rendering other lanelet subtypes, such as "road" and "shoulder".Currently, some part of polygon meshes are lacked, and crosswalk polygons are overlapped by road lanelets.
before:
After:
Rendering logic simplification:
subtypeequal to "crosswalk", and skips all others during rendering.