ci: update to run CLI on CI workflow#188
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances testing infrastructure by adding CLI smoke tests to the CI pipeline and refactoring test code to use consistent fixtures. The changes improve test coverage and maintainability by standardizing the way sample data paths are referenced across tests.
- Added CLI smoke tests to the CI workflow for better coverage of command-line tools
- Refactored test fixtures to use centralized
dummy_lanelet_pathfixture - Updated sample dataset path references for consistency
Reviewed Changes
Copilot reviewed 5 out of 32 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/build-and-test.yaml |
Added CLI smoke tests step to run various t4viz and t4sanity commands |
tests/conftest.py |
Added dummy_lanelet_path fixture for consistent lanelet map file path |
tests/lanelet/test_parser.py |
Updated to use new dummy_lanelet_path fixture instead of hardcoded path |
tests/viewer/test_viewer.py |
Updated to use new dummy_lanelet_path fixture instead of hardcoded path |
tests/test_tier4.py |
Renamed fixture and updated dataset path references for consistency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| @pytest.fixture(scope="session") | ||
| def dummy_lanelet_path() -> str: | ||
| return "tests/sample/t4dataset/map/lanelet2_map.osm" |
There was a problem hiding this comment.
Consider using Path objects for file paths to improve cross-platform compatibility and consistency with other fixtures in the codebase.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
What
This pull request introduces improvements to the testing workflow and test code, mainly focused on better test coverage and maintainability. The most important changes include adding CLI smoke tests to the CI pipeline and refactoring the lanelet parser test to use a reusable fixture for the map path.
CI workflow enhancements:
.github/workflows/build-and-test.yamlto run various CLI commands (t4viz scene,t4viz instance,t4viz pointcloud,t4sanity) on sample data as part of the CI process, improving smoke test coverage for CLI tools.Test code improvements:
dummy_lanelet_pathfixture intests/conftest.pyto provide a reusable path to the lanelet map file for tests.test_lanelet_parserintests/lanelet/test_parser.pyto use the newdummy_lanelet_pathfixture, improving test maintainability and consistency.