fix: resolve camera resolution warning#192
Merged
Merged
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a camera resolution warning by enhancing the rendering of sensor calibration to properly handle camera resolution information. The changes add support for passing camera resolution through the rendering pipeline and ensures this information is properly logged for camera modalities.
- Added optional
resolutionparameter to calibration rendering methods - Updated camera sensor rendering to include resolution in
rr.Pinholecalls - Modified helper rendering to pass sample data dimensions for camera sensors
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| t4_devkit/viewer/viewer.py | Added Vector2Like import and resolution parameter to calibration rendering methods |
| t4_devkit/helper/rendering.py | Updated sensor calibration rendering to pass resolution for camera sensors |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This pull request enhances the rendering of sensor calibration, specifically improving support for camera sensors by allowing camera resolution to be passed through the rendering pipeline. The main changes involve updating the
render_calibrationmethods in theRerunViewerto accept an optionalresolutionparameter and ensuring this information is properly handled and logged for camera modalities.Before this PR, the following warning is displayed:
Camera calibration improvements:
render_calibrationand related methods (_render_calibration_with_schema,_render_calibration_without_schema) int4_devkit/viewer/viewer.pyto accept an optionalresolutionparameter, allowing camera resolution (width, height) to be specified and passed through the rendering pipeline. [1] [2] [3] [4] [5] [6]rr.Pinholecall, ensuring that the camera's image size is accurately represented in the visualization._render_sensor_calibrationmethod int4_devkit/helper/rendering.pyto pass the sample data's width and height as resolution when rendering camera calibrations.Type and import updates:
Vector2Liketo the imports fromt4_devkit.typingint4_devkit/viewer/viewer.pyto support the new resolution parameter type.chore: bump to v0.3.0 #191