style: add typing#194
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds type annotations to improve code clarity and documentation for the to_autolabel_model static method in the AutolabelModel class.
- Added explicit type annotation
list | Noneto thexparameter - Updated the docstring to reflect the new type annotation format
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This pull request makes a minor update to the type annotation and docstring for the
to_autolabel_modelstatic method in theAutolabelModelclass. The change improves code clarity and documentation.xparameter in theto_autolabel_modelmethod to explicitly specifylist | None, and revised the docstring to match the new annotation. (t4_devkit/schema/tables/autolabel_metadata.py)