refactor: remove include_warning option#218
Merged
Merged
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
github-actions
Bot
added
documentation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the --include-warning option from the t4sanity CLI, simplifying the interface by eliminating the ability to toggle warning reporting behavior. The refactoring removes both the CLI option and its associated implementation logic.
Key changes:
- Removed the
--include-warningCLI option and parameter from thesanity_checkfunction - Cleaned up the warnings module usage that was previously used to control warning behavior
- Updated documentation to reflect the removed option
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| t4_devkit/sanity/run.py | Removed include_warning parameter, warnings module import, and warning filtering logic |
| t4_devkit/cli/sanity.py | Removed --include-warning CLI option and simplified the sanity_check function call |
| docs/cli/t4sanity.md | Removed documentation for the --include-warning option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This pull request removes the
--include-warningoption from thet4sanityCLI and its associated logic in the codebase. This simplifies the interface by no longer allowing users to toggle warning reporting, and the related code for handling warnings has been cleaned up accordingly.CLI and User Interface Simplification:
--include-warning(-iw) option from thet4sanitycommand-line interface and documentation, so users can no longer specify whether to report warnings.mainfunction int4_devkit/cli/sanity.pyto remove theinclude_warningparameter and its usage.Internal Logic Cleanup:
include_warningflag in thesanity_checkfunction int4_devkit/sanity/run.py, including the use of thewarningsmodule to filter warnings.warningsmodule fromt4_devkit/sanity/run.py.