refactor: remove unused sanity file in common directory#219
Merged
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the entire sanity.py module from the t4_devkit/common directory, eliminating dataset validation functionality that is no longer needed or has been replaced.
Key changes:
- Removed the
DBExceptiondataclass used for storing dataset error/warning information - Removed the
DBStatusenum used for classifying dataset validation states - Removed the
sanity_checkfunction that performed dataset validation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This pull request removes the
sanity.pymodule fromt4_devkit/common, including theDBExceptiondataclass,DBStatusenum, and thesanity_checkfunction. These components handled dataset validation and error reporting. This is a significant code cleanup, likely indicating these features are deprecated or replaced elsewhere.Removed dataset sanity checking utilities:
DBExceptiondataclass, which encapsulated dataset error/warning information.DBStatusenum, which classified dataset statuses as OK, WARNING, or ERROR.sanity_checkfunction, which performed dataset validation and returned structured exception or warning information.