refactor: rename RuleGroup.TIER4 to RuleGroup.TIERIV#226
Merged
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
github-actions
Bot
added
ci
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the RuleGroup enum to use Roman numeral naming convention by renaming TIER4 to TIERIV, ensuring consistency across the codebase.
Key Changes:
- Updated enum member name from
TIER4toTIERIVin theRuleGroupclass - Updated corresponding test assertion to reference the renamed enum member
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| t4_devkit/sanity/registry.py | Renamed RuleGroup.TIER4 enum member to RuleGroup.TIERIV |
| tests/sanity/test_sanity_registry.py | Updated test to reference RuleGroup.TIERIV instead of RuleGroup.TIER4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This pull request updates the naming of one of the enum members in the
RuleGroupclass to improve clarity and consistency. The corresponding test has also been updated to reflect this change.Enum renaming for clarity:
TIER4enum member toTIERIVin theRuleGroupclass int4_devkit/sanity/registry.pyto use Roman numerals for consistency.Test update:
tests/sanity/test_sanity_registry.pyto useTIERIVinstead ofTIER4when checking the mapping from rule IDs.