Skip to content

chore(pointcloud_metainfo): add pointcloud metainfo class#228

Merged
SamratThapa120 merged 9 commits into
mainfrom
feat/pointcloud-metainfo
Nov 18, 2025
Merged

chore(pointcloud_metainfo): add pointcloud metainfo class#228
SamratThapa120 merged 9 commits into
mainfrom
feat/pointcloud-metainfo

Conversation

@SamratThapa120

@SamratThapa120 SamratThapa120 commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

This pull requests updates the PointCloud dataclass to accept a metainfo field with the following structure (example):

{
    "stamp": {
        "sec": 1753168580,
        "nanosec": 47682048
    },
    "sources": [
        {
            "stamp": {
                "sec": 1753168580,
                "nanosec": 48760832
            },
            "idx_begin": 112575,
            "length": 23322,
            "source_id": "REAR_UPPER"
        },
        {
            "stamp": {
                "sec": 1753168580,
                "nanosec": 47682048
            },
            "idx_begin": 100753,
            "length": 11822,
            "source_id": "REAR_LOWER"
        },

In addition, it adds validators to check if the sources cover the entire point cloud and provides helper functions to get the list of source ids.

Copilot AI review requested due to automatic review settings November 18, 2025 06:36
@github-actions github-actions Bot added the new-feature New feature or request label Nov 18, 2025
@github-actions

github-actions Bot commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

☂️ Python Coverage

current status: ❌

Overall Coverage

Lines Covered Coverage Threshold Status
3957 3255 82% 50% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
t4_devkit/dataclass/pointcloud.py 40% 🔴
TOTAL 40% 🔴

updated for commit: 219b857 by action🐍

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds metadata support to the point cloud data handling system. The main changes introduce three new dataclasses (Stamp, PointcloudSourceInfo, and PointCloudMetainfo) to represent structured metadata about point cloud sources, timestamps, and coverage intervals, along with validation logic to ensure metadata consistency.

Key Changes:

  • Added metadata dataclasses with JSON loading capabilities for representing timestamps and source information
  • Implemented validation to ensure source intervals are contiguous, non-overlapping, and cover all points
  • Updated all point cloud classes to accept optional metadata via a new metainfo_filepath parameter in their from_file methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread t4_devkit/dataclass/pointcloud.py
Comment thread t4_devkit/dataclass/pointcloud.py
Comment thread t4_devkit/dataclass/pointcloud.py Outdated

@ktro2828 ktro2828 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamratThapa120 Thank you for your PR! Your updates seem good to me. I left some minor comments, please check them out!

Comment thread t4_devkit/dataclass/pointcloud.py Outdated
Comment thread t4_devkit/dataclass/pointcloud.py Outdated
Comment thread t4_devkit/dataclass/pointcloud.py Outdated
Comment thread t4_devkit/dataclass/pointcloud.py Outdated
Comment thread t4_devkit/dataclass/pointcloud.py Outdated
@ktro2828

Copy link
Copy Markdown
Collaborator

@SamratThapa120 I also opened PR to bump the version to v0.5.0. Let me know if you want to include this PR as well, I will release the new version after merging this PR. #229

@ktro2828 ktro2828 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amadeuszsz amadeuszsz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@amadeuszsz amadeuszsz self-requested a review November 18, 2025 08:24
Comment thread t4_devkit/dataclass/pointcloud.py Outdated
@SamratThapa120 SamratThapa120 merged commit c50b4ce into main Nov 18, 2025
5 checks passed
@SamratThapa120 SamratThapa120 deleted the feat/pointcloud-metainfo branch November 18, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants