chore(pointcloud_metainfo): add pointcloud metainfo class#228
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Pull Request Overview
This pull request adds metadata support to the point cloud data handling system. The main changes introduce three new dataclasses (Stamp, PointcloudSourceInfo, and PointCloudMetainfo) to represent structured metadata about point cloud sources, timestamps, and coverage intervals, along with validation logic to ensure metadata consistency.
Key Changes:
- Added metadata dataclasses with JSON loading capabilities for representing timestamps and source information
- Implemented validation to ensure source intervals are contiguous, non-overlapping, and cover all points
- Updated all point cloud classes to accept optional metadata via a new
metainfo_filepathparameter in theirfrom_filemethods
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ktro2828
left a comment
There was a problem hiding this comment.
@SamratThapa120 Thank you for your PR! Your updates seem good to me. I left some minor comments, please check them out!
|
@SamratThapa120 I also opened PR to bump the version to v0.5.0. Let me know if you want to include this PR as well, I will release the new version after merging this PR. #229 |
… into feat/pointcloud-metainfo
This pull requests updates the
PointClouddataclass to accept a metainfo field with the following structure (example):In addition, it adds validators to check if the sources cover the entire point cloud and provides helper functions to get the list of source ids.