fix: resolve invalid import#232
Merged
Merged
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR resolves an invalid import by standardizing the camera intrinsic type name from CamIntrinsicLike to CameraIntrinsicLike throughout the codebase. This improves naming consistency and readability.
Key changes:
- Updated type imports to use
CameraIntrinsicLikeinstead ofCamIntrinsicLike - Renamed type annotations in function signatures and return types
- Updated docstring references to reflect the new type name
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| t4_devkit/tier4.py | Updated import statement and return type annotation to use CameraIntrinsicLike |
| t4_devkit/viewer/viewer.py | Updated import statement, function parameter type annotations, and docstring references to use CameraIntrinsicLike |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This pull request standardizes the naming of the camera intrinsic type throughout the codebase by renaming
CamIntrinsicLiketoCameraIntrinsicLikein both type annotations and documentation. This change improves code readability and consistency.Type annotation and import renaming:
CamIntrinsicLiketoCameraIntrinsicLikein type annotations and imports in botht4_devkit/tier4.pyandt4_devkit/viewer/viewer.pyto maintain consistent naming. [1] [2] [3] [4] [5]Documentation updates:
CameraIntrinsicLikeinstead ofCamIntrinsicLikefor parameters describing the camera intrinsic matrix. [1] [2]