fix: align return to type to its hint#234
Merged
Merged
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves type consistency by ensuring utility functions return native Python types instead of NumPy types. This prevents potential type-related bugs and improves interoperability with code expecting standard Python types.
Key Changes:
- Converted NumPy boolean returns to Python
boolin visibility checks - Converted NumPy scalar distance to Python
floatusing.item()
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| t4_devkit/dataclass/box.py | Modified distance_box to return native Python float instead of NumPy scalar |
| t4_devkit/common/geometry.py | Added explicit bool casting to is_box_in_image return statements for type consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
1 similar comment
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This pull request makes minor improvements to type consistency and return values in geometry and box utility functions. The changes ensure that functions always return native Python types instead of NumPy types, which can help prevent subtle bugs and improve interoperability.
is_box_in_imagefunction ingeometry.pyto explicitly cast NumPy boolean results to Pythonboolbefore returning, ensuring consistent return types.distance_boxfunction inbox.pyto return a native Pythonfloatusing.item(), rather than a NumPy scalar, for better type consistency.