Skip to content

fix: align return to type to its hint #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktro2828 merged 1 commit into from
Nov 19, 2025
Merged

fix: align return to type to its hint #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions t4_devkit/common/geometry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,9 @@ def is_box_in_image(
in_front = corners_3d[2, :] > 0.1 # True if a corner is at least 0.1 meter in front of camera.

if visibility == VisibilityLevel.FULL:
return np.all(is_visible) and np.all(in_front)
return bool(np.all(is_visible) and np.all(in_front))
elif visibility in (VisibilityLevel.MOST, VisibilityLevel.PARTIAL):
return np.any(is_visible)
return bool(np.any(is_visible))
elif visibility == VisibilityLevel.NONE:
return True
else:
Expand Down
2 changes: 1 addition & 1 deletion t4_devkit/dataclass/box.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def distance_box(box: BoxLike, tf_matrix: HomogeneousMatrix) -> float | None:
else:
raise TypeError(f"Unexpected box type: {type(box)}")

return np.linalg.norm(position)
return np.linalg.norm(position).item()


@define(eq=False)
Expand Down
Loading