Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions t4_devkit/schema/tables/autolabel_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,12 @@ class AutolabelModel:

name: str = field(validator=validators.instance_of(str))
score: float = field(
validator=[
validators.instance_of(float),
validators.and_(validators.ge(0.0), validators.le(1.0)),
]
validator=(validators.instance_of(float), validators.ge(0.0), validators.le(1.0))
)
uncertainty: float | None = field(
default=None,
validator=validators.optional(
(validators.instance_of(float), validators.and_(validators.ge(0.0), validators.le(1.0)))
validators.and_(validators.instance_of(float), validators.ge(0.0), validators.le(1.0))
),
)

Expand Down
16 changes: 11 additions & 5 deletions t4_devkit/schema/tables/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,23 @@
__all__ = ["SchemaBase", "SchemaTable"]


def impossible_empty(instance, attribute, value: Sized) -> None:
"""A validator that raises ValueError if value is empty."""
if len(value) == 0:
raise ValueError(f"{attribute.name} cannot be empty")
def impossible_empty():
"""Factory function that returns a validator instance which raises ValueError if value is empty."""
return _ImpossibleEmptyValidator()


@define(slots=True, unsafe_hash=True)
class _ImpossibleEmptyValidator:
def __call__(self, instance, attribute, value: Sized) -> None:
if len(value) == 0:
raise ValueError(f"{attribute.name} cannot be empty")


@define
class SchemaBase(ABC):
"""Abstract base dataclass of schema tables."""

token: str = field(validator=(validators.instance_of(str), impossible_empty))
token: str = field(validator=(validators.instance_of(str), impossible_empty()))

@classmethod
def from_json(cls, filepath: str) -> list[SchemaTable]:
Expand Down
2 changes: 1 addition & 1 deletion t4_devkit/schema/tables/calibrated_sensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class CalibratedSensor(SchemaBase):
camera_distortion (CameraDistortion): Camera distortion array. Empty for sensors that are not cameras.
"""

sensor_token: str = field(validator=(validators.instance_of(str), impossible_empty))
sensor_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
translation: Vector3 = field(converter=Vector3)
rotation: Quaternion = field(converter=to_quaternion)
camera_intrinsic: CameraIntrinsic = field(converter=CameraIntrinsic)
Expand Down
2 changes: 1 addition & 1 deletion t4_devkit/schema/tables/instance.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class Instance(SchemaBase):
Empty if the dataset only contains 2D annotations.
"""

category_token: str = field(validator=(validators.instance_of(str), impossible_empty))
category_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
instance_name: str = field(validator=validators.instance_of(str))
nbr_annotations: int = field(validator=validators.instance_of(int))
first_annotation_token: str = field(validator=validators.instance_of(str))
Expand Down
6 changes: 3 additions & 3 deletions t4_devkit/schema/tables/keypoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ class Keypoint(SchemaBase):
num_keypoints (int): The number of keypoints to be annotated.
"""

sample_data_token: str = field(validator=(validators.instance_of(str), impossible_empty))
instance_token: str = field(validator=(validators.instance_of(str), impossible_empty))
sample_data_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
instance_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
category_tokens: list[str] = field(
validator=validators.deep_iterable((validators.instance_of(str), impossible_empty))
validator=validators.deep_iterable((validators.instance_of(str), impossible_empty()))
)
keypoints: KeypointLike = field(converter=np.array)
num_keypoints: int = field(validator=validators.instance_of(int))
2 changes: 1 addition & 1 deletion t4_devkit/schema/tables/lidarseg.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ class LidarSeg(SchemaBase):
"""

filename: str = field(validator=validators.instance_of(str))
sample_data_token: str = field(validator=(validators.instance_of(str), impossible_empty))
sample_data_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
2 changes: 1 addition & 1 deletion t4_devkit/schema/tables/map.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class Map(SchemaBase):
"""

log_tokens: list[str] = field(
validator=validators.deep_iterable((validators.instance_of(str), impossible_empty))
validator=validators.deep_iterable((validators.instance_of(str), impossible_empty()))
)
category: str = field(validator=validators.instance_of(str))
filename: str = field(validator=validators.instance_of(str))
8 changes: 4 additions & 4 deletions t4_devkit/schema/tables/object_ann.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,11 @@ class ObjectAnn(SchemaBase, AutolabelMixin):
category_name (str): Category name. This should be set after instantiated.
"""

sample_data_token: str = field(validator=(validators.instance_of(str), impossible_empty))
instance_token: str = field(validator=(validators.instance_of(str), impossible_empty))
category_token: str = field(validator=(validators.instance_of(str), impossible_empty))
sample_data_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
instance_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
category_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
attribute_tokens: list[str] = field(
validator=validators.deep_iterable((validators.instance_of(str), impossible_empty))
validator=validators.deep_iterable((validators.instance_of(str), impossible_empty()))
)
bbox: Roi = field(converter=Roi)
mask: RLEMask | None = field(
Expand Down
2 changes: 1 addition & 1 deletion t4_devkit/schema/tables/sample.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class Sample(SchemaBase):
"""

timestamp: int = field(validator=validators.instance_of(int))
scene_token: str = field(validator=(validators.instance_of(str), impossible_empty))
scene_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
next: str = field(validator=validators.instance_of(str))
prev: str = field(validator=validators.instance_of(str))

Expand Down
8 changes: 4 additions & 4 deletions t4_devkit/schema/tables/sample_annotation.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@ class SampleAnnotation(SchemaBase, AutolabelMixin):
category_name (str): Category name. This should be set after instantiated.
"""

sample_token: str = field(validator=(validators.instance_of(str), impossible_empty))
instance_token: str = field(validator=(validators.instance_of(str), impossible_empty))
sample_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
instance_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
attribute_tokens: list[str] = field(
validator=validators.deep_iterable((validators.instance_of(str), impossible_empty))
validator=validators.deep_iterable((validators.instance_of(str), impossible_empty()))
)
visibility_token: str = field(validator=(validators.instance_of(str), impossible_empty))
visibility_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
translation: Vector3 = field(converter=Vector3)
size: Vector3 = field(converter=Vector3)
rotation: Quaternion = field(converter=to_quaternion)
Expand Down
6 changes: 4 additions & 2 deletions t4_devkit/schema/tables/sample_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,10 @@ class SampleData(SchemaBase):
"""

sample_token: str = field(validator=validators.instance_of(str))
ego_pose_token: str = field(validator=(validators.instance_of(str), impossible_empty))
calibrated_sensor_token: str = field(validator=(validators.instance_of(str), impossible_empty))
ego_pose_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
calibrated_sensor_token: str = field(
validator=(validators.instance_of(str), impossible_empty())
)
filename: str = field(validator=validators.instance_of(str))
fileformat: FileFormat = field(converter=FileFormat)
width: int = field(validator=validators.instance_of(int))
Expand Down
6 changes: 3 additions & 3 deletions t4_devkit/schema/tables/scene.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class Scene(SchemaBase):

name: str = field(validator=validators.instance_of(str))
description: str = field(validator=validators.instance_of(str))
log_token: str = field(validator=(validators.instance_of(str), impossible_empty))
log_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
nbr_samples: int = field(validator=validators.instance_of(int))
first_sample_token: str = field(validator=(validators.instance_of(str), impossible_empty))
last_sample_token: str = field(validator=(validators.instance_of(str), impossible_empty))
first_sample_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
last_sample_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
4 changes: 2 additions & 2 deletions t4_devkit/schema/tables/surface_ann.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ class SurfaceAnn(SchemaBase, AutolabelMixin):
category_name (str): Category name. This should be set after instantiated.
"""

sample_data_token: str = field(validator=(validators.instance_of(str), impossible_empty))
category_token: str = field(validator=(validators.instance_of(str), impossible_empty))
sample_data_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
category_token: str = field(validator=(validators.instance_of(str), impossible_empty()))
mask: RLEMask | None = field(
default=None,
converter=lambda x: RLEMask(**x) if isinstance(x, dict) else x,
Expand Down
Loading