refactor: update metrics logic#260
Merged
Merged
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
ktro2828
added a commit
that referenced
this pull request
Feb 11, 2026
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This pull request refactors the buffer update logic in the evaluation metrics codebase, improving code modularity and maintainability. The main changes involve extracting buffer update logic into helper methods for both the Average Precision (AP) and CLEAR metrics, as well as fixing an argument issue in a helper method call.
Refactoring buffer update logic:
_update_buffer_framehelper method inApclass (t4_devkit/evaluation/metric/ap.py). The main_update_buffermethod now delegates frame updates to this helper for improved modularity. [1] [2]_update_buffer_framehelper method inClearclass (t4_devkit/evaluation/metric/clear.py). The main_update_buffermethod now uses this helper. [1] [2]Bug fix:
_is_same_matchinClearclass by passing the correct arguments (current_match,previous_match).Other: