This repository was archived by the owner on Mar 8, 2019. It is now read-only.
Fix space key event issue with Japanese, Chinese (etc) IMEs in Chrome and Safari#382
Open
muan wants to merge 1 commit into
Open
Fix space key event issue with Japanese, Chinese (etc) IMEs in Chrome and Safari#382muan wants to merge 1 commit into
muan wants to merge 1 commit into
Conversation
… and Safari (fixes tiff#177)
|
Thanks for investigating this muan! Looks like it works! |
Author
|
@vietqhoang Thanks for the confirmation! 😄 |
|
👍 |
|
👍 why not merge? |
|
Nice work!! Thank you. |
|
Thank you!! |
|
Thank you!!!!!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #177 where when space bar is hit, the unfinished characters got inserted and interrupted the process of typing, choosing words.
The problem being, in Chrome and Safari, keyup event of SPACE_KEY will be triggered during the process of typing in IMEs that require choosing words before entering; however, in Firefox, keyup event of SPACE_KEY will NOT be triggered during such process, which is the ideal behaviour.
Therefore simply changing keyup to keydown solves the problem. Tested in Chrome and Safari, keydown events of SPACE_KEY would not be triggered during typing, and the behaviour in Firefox stays the same. 😊