This repository was archived by the owner on Mar 8, 2019. It is now read-only.
fix check_attribute parser rule to only set attribute if already set#411
Open
garrytan wants to merge 1 commit into
Open
fix check_attribute parser rule to only set attribute if already set#411garrytan wants to merge 1 commit into
garrytan wants to merge 1 commit into
Conversation
|
+1 |
There was a problem hiding this comment.
This extra space should be removed.
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if you set a check_attribute for a given attribute, it would set that attribute even if it wasn't already set. This can clutter up the attributes of the markup quite a bit if you are trying to add custom attributes that will be validated, but you don't want them to show up on every one of those types of tags.
This fix skips validation for check_attribute if the attribute itself is not set at all.