-
Notifications
You must be signed in to change notification settings - Fork 1
feat(cli): add Sentry error telemetry + stabilize flaky stat tests #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1087073
test(cli): retry integration tests to absorb transient gateway flakes
designcode 0db6b15
feat(cli): add Sentry error telemetry
designcode 26a2869
build(cli): declare @types/node in tsconfig for IDE type resolution
designcode 7385bcd
fix(cli): stop sending argv values and risky integration data to Sentry
designcode 6eba826
test(repo): fix fork/source teardown ordering and disable rebase/merg…
designcode a855c35
fix(cli): stop injecting the match offset into redacted telemetry text
designcode 53ef3c7
fix(cli): send scrubbed command context and exit code to Sentry telem…
designcode acde6e1
fix(cli): prevent secret leak in scrubArgv --flag=value handling
designcode a8277ce
fix(cli): redact the --key alias for --access-key in telemetry
designcode 1c0b044
fix(cli): recursively scrub all Sentry event fields before send
designcode b5c611d
fix(cli): guard crash handler against re-entrant exit loop
designcode 50802c5
fix(cli): redact sensitive short flag aliases in telemetry (-t token)
designcode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| "@tigrisdata/cli": minor | ||
| --- | ||
|
|
||
| Add Sentry error telemetry to the CLI. Crashes (uncaught exceptions and | ||
| unhandled rejections) are reported and flushed reliably; unexpected "general" | ||
| and network errors on the handled path are captured best-effort. Events are | ||
| enriched with the command, error category, exit code, CLI version, and platform. | ||
| Secrets (access keys, tokens, credential flags) and the machine hostname are | ||
| scrubbed before any event is sent. Telemetry is off in dev/test and when no DSN | ||
| is configured, and can be disabled with `TIGRIS_NO_TELEMETRY=1` or the standard | ||
| `DO_NOT_TRACK=1`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.