refactor: remove build mode leftovers

kanfil · kanfil · commit b8ea25137783 · 2026-03-06T21:20:41.000+02:00
Remove all references to the removed build mode architecture:

- Delete mode_defaults dict from spec_cli/__init__.py
- Delete get_mode_config() and get_current_mode() functions from scripts
- Delete detect-workflow-config.sh script
- Remove build mode cases from rollback functions
- Update build mode references in templates and docs
- Always perform blocking micro-reviews (spec mode default)
- Remove atomic_commits guidance from task context

Build mode was removed from core commands but leftover code remained,
causing dead code paths and configuration inconsistencies.
diff --git a/scripts/bash/check-prerequisites.sh b/scripts/bash/check-prerequisites.sh
@@ -147,12 +147,6 @@ print(json.dumps(risks, ensure_ascii=False))
 PY
 }
 
-# Extract mode configuration - always returns spec mode for core commands
-get_mode_config() {
-    # Core commands always use spec mode
-    echo '{"current_mode":"spec","options":{"tdd_enabled":true,"contracts_enabled":true,"data_models_enabled":true,"risk_tests_enabled":true}}'
-}
-
 # Get feature paths and validate branch
 eval $(get_feature_paths)
 check_feature_branch "$CURRENT_BRANCH" "$HAS_GIT" || exit 1
@@ -240,7 +234,6 @@ if $JSON_MODE; then
     
     SPEC_RISKS=$(extract_risks "$FEATURE_SPEC")
     PLAN_RISKS=$(extract_risks "$IMPL_PLAN")
-    MODE_CONFIG=$(get_mode_config)
     
     # Check for constitution and architecture (optional governance documents)
     CONSTITUTION_EXISTS="false"
@@ -260,8 +253,8 @@ if $JSON_MODE; then
         ARCHITECTURE_DIAGRAMS=$(extract_architecture_diagrams "$ARCHITECTURE")
     fi
     
-    printf '{"FEATURE_DIR":"%s","AVAILABLE_DOCS":%s,"SPEC_RISKS":%s,"PLAN_RISKS":%s,"MODE_CONFIG":%s,"CONSTITUTION":"%s","CONSTITUTION_EXISTS":%s,"CONSTITUTION_RULES":%s,"ARCHITECTURE":"%s","ARCHITECTURE_EXISTS":%s,"ARCHITECTURE_VIEWS":%s,"ARCHITECTURE_DIAGRAMS":%s}\n' \
-        "$FEATURE_DIR" "$json_docs" "$SPEC_RISKS" "$PLAN_RISKS" "$MODE_CONFIG" \
+    printf '{"FEATURE_DIR":"%s","AVAILABLE_DOCS":%s,"SPEC_RISKS":%s,"PLAN_RISKS":%s,"CONSTITUTION":"%s","CONSTITUTION_EXISTS":%s,"CONSTITUTION_RULES":%s,"ARCHITECTURE":"%s","ARCHITECTURE_EXISTS":%s,"ARCHITECTURE_VIEWS":%s,"ARCHITECTURE_DIAGRAMS":%s}\n' \
+        "$FEATURE_DIR" "$json_docs" "$SPEC_RISKS" "$PLAN_RISKS" \
         "$CONSTITUTION" "$CONSTITUTION_EXISTS" "$CONSTITUTION_RULES" \
         "$ARCHITECTURE" "$ARCHITECTURE_EXISTS" "$ARCHITECTURE_VIEWS" "$ARCHITECTURE_DIAGRAMS"
 else
diff --git a/scripts/bash/common.sh b/scripts/bash/common.sh
@@ -35,37 +35,6 @@ get_config_path() {
     fi
 }
 
-# Get current workflow mode - always returns "spec" for core commands
-get_current_mode() {
-    # Core commands always use spec mode
-    echo "spec"
-}
-
-# Get a specific mode configuration value
-# Usage: get_mode_config "atomic_commits" → returns "true" or "false"
-# Usage: get_mode_config "skip_micro_review" → returns "true" or "false"
-get_mode_config() {
-    local key="$1"
-    local config_file
-    config_file=$(get_config_path)
-    
-    # Default to false if no config exists or jq not available
-    if [[ ! -f "$config_file" ]] || ! command -v jq >/dev/null 2>&1; then
-        echo "false"
-        return
-    fi
-    
-    # Get current mode
-    local mode
-    mode=$(get_current_mode)
-    
-    # Read mode-specific config value, default to false
-    local value
-    value=$(jq -r ".mode_defaults.${mode}.${key} // false" "$config_file" 2>/dev/null)
-    
-    echo "$value"
-}
-
 # Get architecture diagram format from config (mermaid or ascii)
 # Defaults to "mermaid" if config doesn't exist or format is invalid
 get_architecture_diagram_format() {
@@ -398,21 +367,6 @@ except Exception as e:
 PY
 }
 
-# Detect workflow mode and framework options from spec.md
-# Usage: detect_workflow_config [path/to/spec.md]
-# Returns JSON: {"mode":"build|spec","tdd":true|false,"contracts":true|false,"data_models":true|false,"risk_tests":true|false}
-detect_workflow_config() {
-    local spec_file="${1:-spec.md}"
-    
-    # Source the standalone script
-    local script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-    source "$script_dir/detect-workflow-config.sh"
-    
-    # Call the function
-    detect_workflow_config "$spec_file"
-}
-
-
 # Extract diagram blocks from architecture.md
 # Returns JSON array of diagrams with type and format
 extract_architecture_diagrams() {
diff --git a/scripts/bash/detect-workflow-config.sh b/scripts/bash/detect-workflow-config.sh
diff --git a/scripts/bash/implement.sh b/scripts/bash/implement.sh
@@ -287,23 +287,8 @@ execute_task() {
             # Mark as completed (in real implementation, this would happen after successful execution)
             safe_json_update "$TASKS_META_FILE" --arg task_id "$task_id" '.tasks[$task_id].status = "completed"'
 
-            # Conditional micro-review based on mode
-            local skip_review
-            skip_review=$(get_mode_config "skip_micro_review")
-            
-            if [[ "$skip_review" == "true" ]]; then
-                # Build/GSD mode: Non-blocking, log for post-hoc review
-                log_info "Task $task_id complete - Atomic commit created"
-                if command -v git >/dev/null 2>&1; then
-                    local last_commit
-                    last_commit=$(git log -1 --oneline 2>/dev/null || echo "No git repository")
-                    log_info "Commit: $last_commit"
-                fi
-                log_info "Review at any time with: git log -p, git show, git diff"
-            else
-                # Spec mode: Blocking review gate
-                perform_micro_review "$TASKS_META_FILE" "$task_id"
-            fi
+            # Spec mode: Always perform blocking micro-review gate
+            perform_micro_review "$TASKS_META_FILE" "$task_id"
         else
             handle_task_failure "$task_id" "SYNC task execution failed"
         fi
@@ -502,13 +487,13 @@ Choose (1-5): "
             safe_json_update "$TASKS_META_FILE" --arg task_id "$task_id" '.tasks[$task_id].status = "pending"'
             ;;
         2)
-            log_info "Rolling back task $task_id with $mode mode strategy"
-            execute_mode_aware_rollback "$FEATURE_DIR" "task" "$mode" "$task_id"
+            log_info "Rolling back task $task_id"
+            execute_rollback "$FEATURE_DIR" "task" "$task_id"
             ensure_documentation_consistency "$FEATURE_DIR"
             ;;
         3)
             log_info "Rolling back entire feature and regenerating tasks"
-            execute_mode_aware_rollback "$FEATURE_DIR" "feature" "$mode"
+            execute_rollback "$FEATURE_DIR" "feature"
             regenerate_tasks_after_rollback "$FEATURE_DIR" "$failure_reason"
             ensure_documentation_consistency "$FEATURE_DIR"
             ;;
diff --git a/scripts/bash/setup-plan.sh b/scripts/bash/setup-plan.sh
@@ -42,14 +42,8 @@ fi
 # Ensure the feature directory exists
 mkdir -p "$FEATURE_DIR"
 
-# Detect current workflow mode and select appropriate plan template
-CURRENT_MODE=$(get_current_mode)
-
-if [[ "$CURRENT_MODE" == "build" ]]; then
-    TEMPLATE="$REPO_ROOT/.specify/templates/plan-template-build.md"
-else
-    TEMPLATE="$REPO_ROOT/.specify/templates/plan-template.md"
-fi
+# Select plan template
+TEMPLATE="$REPO_ROOT/.specify/templates/plan-template.md"
 
 if [[ -f "$TEMPLATE" ]]; then
     cp "$TEMPLATE" "$IMPL_PLAN"
diff --git a/scripts/bash/spec-hooks-install.sh b/scripts/bash/spec-hooks-install.sh
@@ -168,20 +168,6 @@ function create_config {
     "data_models_enabled": false,
     "risk_tests_enabled": false
   },
-  "mode_defaults": {
-    "build": {
-      "tdd_enabled": false,
-      "contracts_enabled": false,
-      "data_models_enabled": false,
-      "risk_tests_enabled": false
-    },
-    "spec": {
-      "tdd_enabled": true,
-      "contracts_enabled": true,
-      "data_models_enabled": true,
-      "risk_tests_enabled": true
-    }
-  },
   "spec_sync": {
     "enabled": true,
     "queue": {
diff --git a/scripts/bash/tasks-meta-utils.sh b/scripts/bash/tasks-meta-utils.sh
@@ -189,25 +189,6 @@ generate_delegation_prompt() {
 
 ${agent_context}"
 
-    # Add atomic commits guidance if enabled
-    local atomic_commits
-    atomic_commits=$(get_mode_config "atomic_commits")
-    
-    if [[ "$atomic_commits" == "true" ]]; then
-        full_context="${full_context}
-
-## COMMIT STRUCTURE GUIDANCE
-Create atomic commits following this pattern:
-- Each commit represents one logical unit of work
-- Independently reviewable (can understand from commit message + diff)
-- Self-contained (feature complete or milestone complete)
-- Descriptive message: \"[Feature]: What was accomplished\"
-Example: \"[auth]: Implement JWT token validation\"
-
-This enables post-execution review and rollback capability.
-"
-    fi
-
     # Substitute variables using awk to handle multiline content safely
     local prompt
     prompt=$(awk -v agent_type="$agent_type" \
@@ -637,66 +618,29 @@ ensure_documentation_consistency() {
     fi
 }
 
-# Mode-aware rollback strategies
-get_mode_aware_rollback_strategy() {
-    local mode="${1:-spec}"  # Default to spec mode
+# Execute rollback (spec mode only)
+execute_rollback() {
+    local feature_dir="$1"
+    local rollback_type="$2"
+    local task_id="${3:-}"  # Optional task_id for task rollback
+
+    echo "Executing spec_mode_rollback for $rollback_type"
 
-    case "$mode" in
-        "build")
-            echo "build_mode_rollback"
+    case "$rollback_type" in
+        "task")
+            if [[ -z "$task_id" ]]; then
+                echo "ERROR: task_id required for task rollback" >&2
+                return 1
+            fi
+            rollback_task "$feature_dir/tasks_meta.json" "$task_id" "true"
             ;;
-        "spec")
-            echo "spec_mode_rollback"
+        "feature")
+            rollback_feature "$feature_dir" "true"
             ;;
         *)
-            echo "default_rollback"
-            ;;
-    esac
-}
-
-# Execute mode-aware rollback
-execute_mode_aware_rollback() {
-    local feature_dir="$1"
-    local rollback_type="$2"
-    local mode="${3:-spec}"
-
-    local strategy
-    strategy=$(get_mode_aware_rollback_strategy "$mode")
-
-    echo "Executing $strategy for $rollback_type in $mode mode"
-
-    case "$strategy" in
-        "build_mode_rollback")
-            # Lightweight rollback for build mode
-            echo "Build mode: Minimal rollback preserving rapid iteration artifacts"
-            case "$rollback_type" in
-                "task")
-                    # Less aggressive task rollback in build mode
-                    echo "Task rollback completed with minimal cleanup"
-                    ;;
-                "feature")
-                    # Preserve more artifacts in build mode
-                    echo "Feature rollback completed, preserving iteration artifacts"
-                    ;;
-            esac
-            ;;
-
-        "spec_mode_rollback")
-            # Comprehensive rollback for spec mode
-            echo "Spec mode: Comprehensive rollback with full documentation preservation"
-            case "$rollback_type" in
-                "task")
-                    rollback_task "$feature_dir/tasks_meta.json" "$4" "true"
-                    ;;
-                "feature")
-                    rollback_feature "$feature_dir" "true"
-                    ;;
-            esac
+            echo "ERROR: Unknown rollback type: $rollback_type" >&2
+            return 1
             ;;
-
-        "default_rollback")
-    echo "Default rollback strategy applied"
-    ;;
     esac
 }
 
@@ -717,37 +661,18 @@ get_framework_opinions() {
         local user_risk_tests
         user_risk_tests=$(jq -r ".options.risk_tests_enabled" "$config_file" 2>/dev/null || echo "null")
 
-        # Fill in defaults for unset options based on mode
-        case "$mode" in
-            "build")
-                [[ "$user_tdd" == "null" ]] && user_tdd="false"
-                [[ "$user_contracts" == "null" ]] && user_contracts="false"
-                [[ "$user_data_models" == "null" ]] && user_data_models="false"
-                [[ "$user_risk_tests" == "null" ]] && user_risk_tests="false"
-                ;;
-            "spec")
-                [[ "$user_tdd" == "null" ]] && user_tdd="true"
-                [[ "$user_contracts" == "null" ]] && user_contracts="true"
-                [[ "$user_data_models" == "null" ]] && user_data_models="true"
-                [[ "$user_risk_tests" == "null" ]] && user_risk_tests="true"
-                ;;
-        esac
+        # Fill in defaults for unset options (spec mode defaults)
+        [[ "$user_tdd" == "null" ]] && user_tdd="true"
+        [[ "$user_contracts" == "null" ]] && user_contracts="true"
+        [[ "$user_data_models" == "null" ]] && user_data_models="true"
+        [[ "$user_risk_tests" == "null" ]] && user_risk_tests="true"
+
         echo "tdd_enabled=$user_tdd contracts_enabled=$user_contracts data_models_enabled=$user_data_models risk_tests_enabled=$user_risk_tests"
         return
     fi
 
-    # Fallback to mode-based defaults
-    case "$mode" in
-        "build")
-            echo "tdd_enabled=false contracts_enabled=false data_models_enabled=false risk_tests_enabled=false"
-            ;;
-        "spec")
-            echo "tdd_enabled=true contracts_enabled=true data_models_enabled=true risk_tests_enabled=true"
-            ;;
-        *)
-            echo "tdd_enabled=false contracts_enabled=false data_models_enabled=false risk_tests_enabled=false"
-            ;;
-    esac
+    # Fallback to spec mode defaults
+    echo "tdd_enabled=true contracts_enabled=true data_models_enabled=true risk_tests_enabled=true"
 }
 
 # Set framework opinion (legacy compatibility - now handled by per-spec mode)
@@ -856,12 +781,12 @@ if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
             shift
             regenerate_tasks_after_rollback "$@"
             ;;
-        regenerate_plan|ensure_documentation_consistency|        get_mode_aware_rollback_strategy|execute_mode_aware_rollback|        get_framework_opinions|set_framework_opinion|is_opinion_enabled|generate_tasks_with_opinions)
+        regenerate_plan|ensure_documentation_consistency|        execute_rollback|        get_framework_opinions|set_framework_opinion|is_opinion_enabled|generate_tasks_with_opinions)
             shift
             "$1" "$@"
             ;;
         *)
-            echo "Usage: $0 {generate_delegation_prompt|check_delegation_status|dispatch_async_task|analyze_implementation_changes|propose_documentation_updates|apply_documentation_updates|rollback_task|rollback_feature|regenerate_tasks_after_rollback|regenerate_plan|ensure_documentation_consistency|get_mode_aware_rollback_strategy|execute_mode_aware_rollback} [args...]"
+            echo "Usage: $0 {generate_delegation_prompt|check_delegation_status|dispatch_async_task|analyze_implementation_changes|propose_documentation_updates|apply_documentation_updates|rollback_task|rollback_feature|regenerate_tasks_after_rollback|regenerate_plan|ensure_documentation_consistency|execute_rollback} [args...]"
             exit 1
             ;;
     esac
diff --git a/spec-driven.md b/spec-driven.md
@@ -97,7 +97,7 @@ Once a feature specification exists, this command creates a comprehensive implem
 
 After a plan is created, this command analyzes the plan and related design documents to generate an executable task list:
 
-1. **Inputs**: Reads `plan.md` (required in spec mode, optional in build mode) and, if present, `data-model.md`, `contracts/`, and `research.md`
+1. **Inputs**: Reads `plan.md` and, if present, `data-model.md`, `contracts/`, and `research.md`
 2. **Task Derivation**: Converts contracts, entities, and scenarios into specific tasks
 3. **Parallelization**: Marks independent tasks `[P]` and outlines safe parallel groups
 4. **Output**: Writes `tasks.md` in the feature directory, ready for execution by a Task agent
diff --git a/src/specify_cli/__init__.py b/src/specify_cli/__init__.py
@@ -718,28 +718,6 @@ def get_default_config() -> dict:
             "data_models_enabled": False,
             "risk_tests_enabled": False,
         },
-        "mode_defaults": {
-            "build": {
-                "tdd_enabled": False,
-                "contracts_enabled": False,
-                "data_models_enabled": False,
-                "risk_tests_enabled": False,
-                # GSD execution characteristics
-                "atomic_commits": True,
-                "skip_micro_review": True,
-                "minimal_documentation": True,
-            },
-            "spec": {
-                "tdd_enabled": True,
-                "contracts_enabled": True,
-                "data_models_enabled": True,
-                "risk_tests_enabled": True,
-                # Spec mode review characteristics
-                "atomic_commits": False,
-                "skip_micro_review": False,
-                "minimal_documentation": False,
-            },
-        },
         "spec_sync": {
             "enabled": False,
             "queue": {"version": "1.0", "created": now, "pending": [], "processed": []},
diff --git a/templates/tasks-template.md b/templates/tasks-template.md
