Conversation
Remove the AI pre-calculation of branch numbers which was incorrectly matching only branches with the exact short-name pattern. This caused duplicate 001 prefixes when creating different features. Now the script auto-detects the next global number by checking ALL existing branches and specs directories, ensuring unique sequential numbering (001, 002, 003...) regardless of feature short-names. The bash script already had the correct global numbering logic in get_highest_from_branches() and check_existing_branches() functions. Fixes: #34 Related upstream issues: github#1066, github#1332, github#1454 Aligned with upstream PR: github#1466
|
|
📊 Eval ResultsOverall: 7/25 tests passed (28%)
❌ Failed Tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the bug where
spec.specifycreates multiple branches with the same001prefix when creating different features.Problem
The AI instructions in
templates/commands/specify.mdwere telling the agent to:*-user-auth)This caused the following scenario:
001-user-auth001-payment-gateway(DUPLICATE - should be002)001-analytics-dashboard(DUPLICATE - should be003)Solution
Remove the AI pre-calculation of branch numbers and let the bash script handle numbering automatically. The script already has the correct global numbering logic in:
get_highest_from_branches()- checks ALL branches regardless of short-namecheck_existing_branches()- combines branches and specs to find the next global numberBefore (broken)
After (fixed)
Related Issues
Testing
After this fix:
001-user-auth002-payment-gateway(correct!)003-analytics-dashboard(correct!)