Fix AssetMinification tests: correct mocks, urlToPath, and test structure

Author: tikhomirov

composer.lock

@@ -402,7 +402,11 @@ private function getAssetPriority(string $handle): int
 
     private function urlToPath(string $url): string
     {
-        return str_replace(site_url(), ABSPATH, $url);
+        if (!$url) {
+            return '';
+        }
+        $path = str_replace(site_url(), '', $url);
+        return rtrim(ABSPATH, '/') . '/' . ltrim($path, '/');
     }
 
     private function getCacheUrl(string $key): string

functions/AssetMinification.php

@@ -283,7 +283,7 @@
 
     it('converts URL to path', function () {
         $url = 'http://localhost/wp-content/themes/theme/style.css';
-        $expectedPath = '/var/www/no-borders.ru//wp-content/themes/theme/style.css';
+        $expectedPath = ABSPATH . 'wp-content/themes/theme/style.css';
 
         $reflection = new \ReflectionClass($this->assetMinification);
         $method = $reflection->getMethod('urlToPath');

test-results.xml

@@ -1,15 +1,17 @@
 <?php
 
-describe('AssetMinification', function () {
-    beforeAll(function() {
-        if (!function_exists('site_url')) {
-            function site_url() {
-                return 'http://localhost';
-            }
+beforeAll(function() {
+    if (!function_exists('site_url')) {
+        function site_url() {
+            return 'http://localhost';
         }
-    });
+    }
+});
+
+describe('AssetMinification', function () {
 
     it('creates cache files for CSS assets', function () {
+        $cacheDir = sys_get_temp_dir() . '/wp_addon_cache/';
         $optionService = \Mockery::mock('\\WpAddon\\Services\\OptionService');
         $assetMinification = new \AssetMinification($optionService);
 
@@ -53,8 +55,11 @@ function site_url() {
         ];
 
         // Mock ABSPATH for urlToPath
-        if (!defined('ABSPATH')) {
-            define('ABSPATH', sys_get_temp_dir() . '/');
+        define('ABSPATH', sys_get_temp_dir() . '/');
+
+        // Ensure cache dir exists
+        if (!is_dir($cacheDir)) {
+            mkdir($cacheDir, 0755, true);
         }
 
         // Initialize
@@ -64,7 +69,6 @@ function site_url() {
         $assetMinification->processAssets();
 
         // Check if cache file was created
-        $cacheDir = sys_get_temp_dir() . '/wp_addon_cache/';
         $files = glob($cacheDir . '*.gz');
 
         expect(count($files))->toBeGreaterThan(0, 'Cache file should be created');
@@ -77,6 +81,7 @@ function site_url() {
     });
 
     it('creates cache files for JS assets', function () {
+        $cacheDir = sys_get_temp_dir() . '/wp_addon_cache/';
         $optionService = \Mockery::mock('\\WpAddon\\Services\\OptionService');
         $assetMinification = new \AssetMinification($optionService);
 
@@ -120,8 +125,11 @@ function site_url() {
         ];
 
         // Mock ABSPATH for urlToPath
-        if (!defined('ABSPATH')) {
-            define('ABSPATH', sys_get_temp_dir() . '/');
+        define('ABSPATH', sys_get_temp_dir() . '/');
+
+        // Ensure cache dir exists
+        if (!is_dir($cacheDir)) {
+            mkdir($cacheDir, 0755, true);
         }
 
         // Initialize
@@ -131,7 +139,6 @@ function site_url() {
         $assetMinification->processAssets();
 
         // Check if cache file was created
-        $cacheDir = sys_get_temp_dir() . '/wp_addon_cache/';
         $files = glob($cacheDir . '*.gz');
 
         expect(count($files))->toBeGreaterThan(0, 'Cache file should be created');

tests/Unit/AssetMinificationSmartLogicTest.php

@@ -129,7 +129,7 @@ function add_option($key, $value, $deprecated = '', $autoload = 'yes') {
 $mock_functions = [];
 
 if (!defined('ABSPATH')) {
-    define('ABSPATH', '/var/www/no-borders.ru/');
+    define('ABSPATH', '/tmp/');
 }
 
 if (!defined('WP_CONTENT_DIR')) {
@@ -283,13 +283,13 @@ function file_exists($filename) {
 
 if (!function_exists('is_dir')) {
     function is_dir($filename) {
-        return true;
+        return \is_dir($filename);
     }
 }
 
 if (!function_exists('mkdir')) {
     function mkdir($filename, $mode = 0777, $recursive = false) {
-        return true;
+        return \mkdir($filename, $mode, $recursive);
     }
 }
 
@@ -332,31 +332,30 @@ function file_get_contents($filename) {
 
 if (!function_exists('file_put_contents')) {
     function file_put_contents($filename, $data) {
-        return strlen($data);
+        return \file_put_contents($filename, $data);
     }
 }
 
 if (!function_exists('gzcompress')) {
     function gzcompress($data, $level = -1) {
-        return $data . '_compressed';
+        return \gzcompress($data, $level);
     }
 }
 
 if (!function_exists('gzuncompress')) {
     function gzuncompress($data) {
-        global $mock_functions;
-        return $mock_functions['gzuncompress'] ?? str_replace('_compressed', '', $data);
+        return \gzuncompress($data);
     }
 }
 
 if (!function_exists('md5')) {
     function md5($str) {
-        return 'mock_md5_' . $str;
+        return \md5($str);
     }
 }
 
 if (!function_exists('time')) {
     function time() {
-        return 1234567890;
+        return \time();
     }
 }

tests/Unit/AssetMinificationTest.php

@@ -1,6 +1,6 @@
 <?php
 /**
- * Plugin Name:  WP Excellence Addon
+ * Plugin Name:  # WP Excellence Addon
  * Plugin URL:   https://rwsite.ru
  * Description:  Transforms your standard WordPress installation into an excellent, optimized website with comprehensive performance, security, and usability enhancements.
  * Version:      1.3.2
@@ -13,7 +13,7 @@
  *
  * Requires at least: 6.6
  * Tested up to: 6.8.3
- * Requires PHP: 8.2+
+ * Requires PHP: 7.4+
  */
 
 defined('ABSPATH') || exit;