*: update kvproto to apiv3 - #2024
Conversation
Signed-off-by: disksing <i@disksing.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (10)
📝 WalkthroughWalkthroughUpdates Go modules to Go 1.25.10 and newer dependency revisions, while migrating keyspace protobuf handling from direct fields to wrapper types and generated accessors across codecs, safe-point logic, integration tests, and test fixtures. ChangesKeyspace compatibility and module updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
internal/apicodec/codec_v2_test.go (1)
887-887: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueSwap arguments to match
testify's expected vs. actual convention.In
testify/suite, theEqualmethod expects arguments in the order(expected, actual). Swapping them ensures that any failure messages will report the expected and actual values correctly instead of inversely.♻️ Proposed refactor
- suite.Equal(task.Meta.GetKeyspaceId(), testKeyspaceID) + suite.Equal(testKeyspaceID, task.Meta.GetKeyspaceId())🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@internal/apicodec/codec_v2_test.go` at line 887, Update the Equal assertion in the relevant test to pass testKeyspaceID as the expected value and task.Meta.GetKeyspaceId() as the actual value, preserving the existing comparison.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@internal/apicodec/codec_v2_test.go`:
- Line 887: Update the Equal assertion in the relevant test to pass
testKeyspaceID as the expected value and task.Meta.GetKeyspaceId() as the actual
value, preserving the existing comparison.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 028004a3-d722-4842-84e1-09af2e9ec1ee
⛔ Files ignored due to path filters (2)
go.sumis excluded by!**/*.sumintegration_tests/go.sumis excluded by!**/*.sum
📒 Files selected for processing (17)
examples/gcworker/go.modexamples/rawkv/go.modexamples/txnkv/1pc_txn/go.modexamples/txnkv/async_commit/go.modexamples/txnkv/delete_range/go.modexamples/txnkv/go.modexamples/txnkv/pessimistic_txn/go.modexamples/txnkv/unsafedestoryrange/go.modgo.modintegration_tests/go.modinternal/apicodec/codec.gointernal/apicodec/codec_v2.gointernal/apicodec/codec_v2_test.gointernal/locate/pd_codec.gotikv/compatible_txn_safe_point_loader.gotikv/test_util.gotikvrpc/tikvrpc_test.go
Signed-off-by: disksing <i@disksing.com>
|
Addressed the CodeRabbit nit in 901d142 by using the expected/actual argument order. This update also moves integration_tests to the APIV3-compatible TiDB revision and fixes the remaining KeyspaceMeta getter; the full integration test module now compiles. |
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
# Conflicts: # examples/gcworker/go.mod # examples/rawkv/go.mod # examples/txnkv/1pc_txn/go.mod # examples/txnkv/async_commit/go.mod # examples/txnkv/delete_range/go.mod # examples/txnkv/go.mod # examples/txnkv/pessimistic_txn/go.mod # examples/txnkv/unsafedestoryrange/go.mod # go.mod # go.sum # integration_tests/go.mod # integration_tests/go.sum
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
What problem does this PR solve?
The kvproto APIV3 branch moves keyspace-related protobuf fields into oneofs, so the current client code no longer compiles against the latest definitions.
What changed?
Tests
go test -tags=intest ./...Summary by CodeRabbit