Skip to content

Commit 91a2aa1

Browse files
move docstring to the public interface
1 parent b3a16da commit 91a2aa1

3 files changed

Lines changed: 50 additions & 30 deletions

File tree

tilebox-datasets/tilebox/datasets/aio/client.py

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,19 +40,40 @@ async def create_dataset(
4040
fields: list[FieldDict],
4141
*,
4242
name: str | None = None,
43-
summary: str | None = None,
43+
description: str | None = None,
4444
) -> DatasetClient:
45+
"""Create a new dataset.
46+
47+
Args:
48+
kind: The kind of the dataset.
49+
code_name: The code name of the dataset.
50+
fields: The fields of the dataset.
51+
name: The name of the dataset. Defaults to the code name.
52+
description: A short description of the dataset. Optional.
53+
54+
Returns:
55+
The created dataset.
56+
"""
4557
if name is None:
4658
name = code_name
47-
if summary is None:
48-
summary = ""
59+
if description is None:
60+
description = ""
4961

50-
return await self._client.create_dataset(kind, code_name, fields, name, summary, DatasetClient)
62+
return await self._client.create_dataset(kind, code_name, fields, name, description, DatasetClient)
5163

5264
async def datasets(self) -> Group:
65+
"""Fetch all available datasets."""
5366
return await self._client.datasets(DatasetClient)
5467

5568
async def dataset(self, slug: str) -> DatasetClient:
69+
"""Get a dataset by its slug, e.g. `open_data.copernicus.sentinel1_sar`.
70+
71+
Args:
72+
slug: The slug of the dataset.
73+
74+
Returns:
75+
The dataset if it exists.
76+
"""
5677
return await self._client.dataset(slug, DatasetClient)
5778

5879
async def _dataset_by_id(self, dataset_id: str | UUID) -> DatasetClient:

tilebox-datasets/tilebox/datasets/client.py

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -29,26 +29,13 @@ def __init__(self, service: TileboxDatasetService) -> None:
2929
def create_dataset( # noqa: PLR0913
3030
self, kind: DatasetKind, code_name: str, fields: list[FieldDict], name: str, summary: str, dataset_type: type[T]
3131
) -> Promise[T]:
32-
"""Create a new dataset.
33-
34-
Args:
35-
kind: The kind of the dataset.
36-
code_name: The code name of the dataset.
37-
fields: The fields of the dataset.
38-
name: The name of the dataset. Defaults to the code name.
39-
summary: A short summary of the dataset. Optional.
40-
41-
Returns:
42-
The created dataset.
43-
"""
4432
return (
4533
self._service.create_dataset(kind, code_name, fields, name, summary)
4634
.then(_ensure_registered)
4735
.then(lambda dataset: dataset_type(self._service, dataset))
4836
)
4937

5038
def datasets(self, dataset_type: type[T]) -> Promise[Group]:
51-
"""Fetch all available datasets."""
5239
return (
5340
self._service.list_datasets()
5441
.then(_log_server_message)
@@ -61,15 +48,6 @@ def datasets(self, dataset_type: type[T]) -> Promise[Group]:
6148
)
6249

6350
def dataset(self, slug: str, dataset_type: type[T]) -> Promise[T]:
64-
"""Get a dataset by its slug, e.g. `open_data.copernicus.sentinel1_sar`.
65-
66-
Args:
67-
slug: The slug of the dataset.
68-
69-
Returns:
70-
The dataset if it exists.
71-
"""
72-
7351
return (
7452
self._service.get_dataset_by_slug(slug)
7553
.then(_ensure_registered)

tilebox-datasets/tilebox/datasets/sync/client.py

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,19 +40,40 @@ def create_dataset(
4040
fields: list[FieldDict],
4141
*,
4242
name: str | None = None,
43-
summary: str | None = None,
43+
description: str | None = None,
4444
) -> DatasetClient:
45+
"""Create a new dataset.
46+
47+
Args:
48+
kind: The kind of the dataset.
49+
code_name: The code name of the dataset.
50+
fields: The fields of the dataset.
51+
name: The name of the dataset. Defaults to the code name.
52+
description: A short description of the dataset. Optional.
53+
54+
Returns:
55+
The created dataset.
56+
"""
4557
if name is None:
4658
name = code_name
47-
if summary is None:
48-
summary = ""
59+
if description is None:
60+
description = ""
4961

50-
return self._client.create_dataset(kind, code_name, fields, name, summary, DatasetClient).get()
62+
return self._client.create_dataset(kind, code_name, fields, name, description, DatasetClient).get()
5163

5264
def datasets(self) -> Group:
65+
"""Fetch all available datasets."""
5366
return self._client.datasets(DatasetClient).get()
5467

5568
def dataset(self, slug: str) -> DatasetClient:
69+
"""Get a dataset by its slug, e.g. `open_data.copernicus.sentinel1_sar`.
70+
71+
Args:
72+
slug: The slug of the dataset.
73+
74+
Returns:
75+
The dataset if it exists.
76+
"""
5677
return self._client.dataset(slug, DatasetClient).get()
5778

5879
def _dataset_by_id(self, dataset_id: str | UUID) -> DatasetClient:

0 commit comments

Comments
 (0)