Fix terminal startup and add browser context for CLI agents#1
Open
theahura wants to merge 1 commit into
Open
Conversation
…ser context The terminal sidebar crashed on startup because Rust CLIs (nori/claude) use crossterm's cursor position query (ESC[6n), which timed out waiting for the response to round-trip through the IPC to xterm.js and back. Three fixes: - Intercept ESC[6n in PTY data handler, respond immediately with ESC[1;1R - Defer PTY spawn until renderer signals xterm.js is ready (terminal-ready IPC) - Create per-session working directory at ~/nori-browser/YYYYMMDD-HHMMSS/ - Pass browser context (Playwright CDP connection info) as CLI args to nori/claude 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
terminal-readyIPC), with a 10s timeout fallback~/nori-browser/YYYYMMDD-HHMMSS/instead of starting in$HOME-c developer_instructions=...) and claude (--append-system-prompt ...) CLIs so the agent knows about the browser from startupTest Plan
npm testpasses (12 tests including 2 new ones)npm run startand confirm the terminal sidebar loads without crashing~/nori-browser/YYYYMMDD-HHMMSS/directoryShare Nori with your team: https://www.npmjs.com/package/nori-skillsets