feat(tui): Complete feature flags implementation with Nori update system

- Add Nori-specific update modules (update_action.rs, updates.rs, update_prompt.rs)
- Gate slash command visibility based on features (login, feedback)
- Add CLI feature propagation to TUI crate
- Update documentation for feature flags architecture
- Remove unnecessary dead code workaround in updates.rs
- Add documentation for get_update_action() design decision

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: CSRessel

codex-rs/cli/Cargo.toml

@@ -23,6 +23,9 @@ full = [
     "app-server",
     "cloud-tasks",
     "login",
+    "feedback",
+    "backend-client",
+    "upstream-updates",
     "mcp-server",
     "chatgpt",
     "responses-api-proxy",
@@ -34,8 +37,17 @@ app-server = ["dep:codex-app-server"]
 # Cloud tasks command
 cloud-tasks = ["dep:codex-cloud-tasks"]
 
-# Login/logout commands
-login = ["dep:codex-login"]
+# Login/logout commands - propagate to TUI
+login = ["dep:codex-login", "codex-tui/login"]
+
+# Feedback feature - propagate to TUI
+feedback = ["codex-tui/feedback"]
+
+# Backend client feature - propagate to TUI
+backend-client = ["codex-tui/backend-client"]
+
+# Upstream updates feature - propagate to TUI
+upstream-updates = ["codex-tui/upstream-updates"]
 
 # MCP server functionality
 mcp-server = ["dep:codex-mcp-server", "dep:codex-rmcp-client"]

codex-rs/cli/docs.md

@@ -75,15 +75,28 @@ The CLI uses Cargo features to enable optional functionality. By default (`defau
 | `full` | All features | Complete legacy binary |
 | `app-server` | `codex-app-server` | `app-server` subcommand |
 | `cloud-tasks` | `codex-cloud-tasks` | `cloud` subcommand |
-| `login` | `codex-login` | `login`/`logout` subcommands |
+| `login` | `codex-login`, `codex-tui/login` | `login`/`logout` subcommands + TUI login |
+| `feedback` | `codex-tui/feedback` | Sentry feedback in TUI |
+| `backend-client` | `codex-tui/backend-client` | Cloud tasks backend client |
+| `upstream-updates` | `codex-tui/upstream-updates` | OpenAI update mechanism (vs Nori's) |
 | `mcp-server` | `codex-mcp-server`, `codex-rmcp-client` | `mcp`, `mcp-server` subcommands |
 | `chatgpt` | `codex-chatgpt` | `apply` subcommand |
 | `responses-api-proxy` | `codex-responses-api-proxy` | `responses-api-proxy` subcommand |
 
+**Feature Propagation to TUI:**
+
+Several CLI features propagate to the TUI crate for coordinated behavior:
+- `login` -> `codex-tui/login`: Enables login screens and `/login` command in TUI
+- `feedback` -> `codex-tui/feedback`: Enables Sentry feedback and `/feedback` command
+- `backend-client` -> `codex-tui/backend-client`: Enables cloud tasks backend
+- `upstream-updates` -> `codex-tui/upstream-updates`: Uses OpenAI update system instead of Nori's
+
+Without these features, the TUI uses Nori-specific alternatives (e.g., GitHub Discussions for feedback, GitHub releases for updates).
+
 Build examples:
 ```bash
-cargo build -p codex-cli                    # Minimal (TUI + exec + ACP only)
-cargo build -p codex-cli --features full    # All functionality
+cargo build -p codex-cli                    # Minimal (TUI + exec + ACP only, Nori updates)
+cargo build -p codex-cli --features full    # All functionality (OpenAI-compatible)
 cargo build -p codex-cli --features login,mcp-server  # Selective
 ```
 

codex-rs/tui/docs.md

@@ -14,9 +14,9 @@ TUI is one of the primary entry points, invoked when running `codex` without a s
 - **Depends on** `codex-acp` for ACP agent backend (alternative to HTTP-based LLM providers)
 - **Depends on** `codex-common` for CLI argument parsing and shared utilities
 - **Uses** `codex-protocol` types for events and messages
-- **Integrates** `codex-feedback` for tracing/feedback collection
+- **Optionally integrates** `codex-feedback`, `codex-login`, `codex-backend-client` via feature flags
 
-The `cli/` crate's `main.rs` dispatches to `codex_tui::run_main()` for interactive mode.
+The `cli/` crate's `main.rs` dispatches to `codex_tui::run_main()` for interactive mode. Feature flags propagate from CLI to TUI for coordinated modular builds.
 
 ### Core Implementation
 
@@ -84,7 +84,7 @@ In `spawn_acp_agent()`, the main task must drop its `Arc<AcpBackend>` reference
 **Onboarding:**
 
 The `onboarding/` module handles first-run experience:
-- Login screen (ChatGPT OAuth or API key)
+- Login screen (ChatGPT OAuth or API key) - requires `login` feature
 - Trust screen (directory permission settings)
 - Windows WSL setup instructions
 
@@ -95,6 +95,33 @@ The `onboarding/` module handles first-run experience:
 
 ### Things to Know
 
+**Feature Flags Architecture:**
+
+The TUI crate uses Cargo feature flags to enable modular builds with two primary modes:
+
+| Feature | Optional Dep | Description |
+|---------|-------------|-------------|
+| `full` | - | Meta-feature enabling all optional features |
+| `login` | `codex-login` | ChatGPT/API login functionality |
+| `feedback` | `codex-feedback` | Sentry feedback integration |
+| `backend-client` | `codex-backend-client` | Cloud tasks backend client |
+| `upstream-updates` | - | OpenAI/Codex update checking mechanism |
+
+Feature gating patterns:
+- Import gating: `#[cfg(feature = "backend-client")] use codex_backend_client::Client`
+- Struct field gating: `#[cfg(feature = "feedback")] feedback: CodexFeedback`
+- Function parameter gating: `#[cfg(feature = "feedback")] feedback: CodexFeedback` in `App::run()`
+- Enum variant gating: `AppEvent::Feedback` only exists with `feedback` feature
+
+**Update System Selection:**
+
+The update checking system is selected at compile time via `upstream-updates`:
+- With `upstream-updates`: Uses `update_action.rs`, `updates.rs`, `update_prompt.rs` from `@/codex-rs/tui/src/`
+- Without `upstream-updates`: Uses Nori-specific versions from `@/codex-rs/tui/src/nori/`
+- Re-exports in `lib.rs` provide unified access: `pub mod update_action` re-exports from either location
+
+Update modules are only compiled in release builds (`#[cfg(not(debug_assertions))]`) to avoid unnecessary checks during development.
+
 **Rendering Patterns:**
 
 The crate uses Ratatui's `Stylize` trait for concise styling:

codex-rs/tui/src/lib.rs

@@ -77,9 +77,31 @@ mod terminal_palette;
 mod text_formatting;
 mod tui;
 mod ui_consts;
+
+// Upstream OpenAI/Codex update modules (only included with upstream-updates feature)
+// The update_action module is available in all builds for the UpdateAction type
+// The update_prompt and updates modules are only for release builds
+#[cfg(feature = "upstream-updates")]
 pub mod update_action;
+#[cfg(all(not(debug_assertions), feature = "upstream-updates"))]
 mod update_prompt;
+#[cfg(all(not(debug_assertions), feature = "upstream-updates"))]
 mod updates;
+
+// Nori-specific update modules (only when NOT using upstream-updates)
+// Re-export as pub mod for external access to UpdateAction type
+#[cfg(not(feature = "upstream-updates"))]
+pub mod update_action {
+    pub use super::nori::update_action::*;
+}
+
+// Re-export the appropriate update prompt functions based on feature (release builds only)
+#[cfg(all(not(debug_assertions), feature = "upstream-updates"))]
+pub(crate) use update_prompt::{UpdatePromptOutcome, run_update_prompt_if_needed};
+
+#[cfg(all(not(debug_assertions), not(feature = "upstream-updates")))]
+pub(crate) use nori::update_prompt::{UpdatePromptOutcome, run_update_prompt_if_needed};
+
 mod version;
 
 mod wrapping;
@@ -388,11 +410,9 @@ async fn run_ratatui_app(
 
     #[cfg(not(debug_assertions))]
     {
-        use crate::update_prompt::UpdatePromptOutcome;
-
         let skip_update_prompt = cli.prompt.as_ref().is_some_and(|prompt| !prompt.is_empty());
         if !skip_update_prompt {
-            match update_prompt::run_update_prompt_if_needed(&mut tui, &initial_config).await? {
+            match run_update_prompt_if_needed(&mut tui, &initial_config).await? {
                 UpdatePromptOutcome::Continue => {}
                 UpdatePromptOutcome::RunUpdate(action) => {
                     crate::tui::restore()?;

codex-rs/tui/src/nori/docs.md

@@ -4,14 +4,16 @@ Path: @/codex-rs/tui/src/nori
 
 ### Overview
 
-The `nori` module contains Nori-specific TUI customizations that replace or extend the default Codex UI behavior. Currently, the primary component is a branded session header that displays at the start of each TUI session.
+The `nori` module contains Nori-specific TUI customizations that replace or extend the default Codex UI behavior. It provides branded session headers, agent picking, feedback redirection, and a Nori-specific update checking mechanism that queries GitHub releases instead of OpenAI's update system.
 
 ### How it fits into the larger codebase
 
 - **Called by** `history_cell.rs` via `new_session_info()` which delegates to `new_nori_session_info()`
 - **Replaces** the original `SessionHeaderHistoryCell` (preserved as dead code for potential future feature flag selection)
 - **Uses** `HistoryCell` trait from `@/codex-rs/tui/src/history_cell.rs` for consistent rendering
 - **Reads** `~/.nori-config.json` for Nori profile information
+- **Conditionally compiled** based on feature flags - modules like `feedback.rs`, `updates.rs` are only included when their corresponding upstream features are disabled
+- **Re-exported** by `@/codex-rs/tui/src/lib.rs` to provide unified access to update types regardless of which update system is active
 
 ### Core Implementation
 
@@ -54,6 +56,33 @@ The banner uses green+bold for alphabetic characters and dark gray for structura
 - `acp_model_picker_params()` renders the `/model` fallback page that disables selection when ACP mode is active and points the user back to `/agent`.
 - `PendingAgentSelection` holds the selected model/display name pair so the App and `ChatWidget` can store it until the next prompt triggers `AppEvent::SubmitWithAgentSwitch`, at which point the conversation is rebuilt with the new model and the picker view is dismissed.
 
+**Feedback Redirect (`feedback.rs`):**
+
+Compiled only when `feedback` feature is disabled (`#[cfg(not(feature = "feedback"))]`). Redirects `/feedback` command to GitHub Discussions instead of OpenAI's feedback system:
+- `NORI_FEEDBACK_URL`: Points to `https://github.com/tilework-tech/nori-cli/discussions`
+- `feedback_message()`: Returns user-facing message with the discussions URL
+
+**Update System (`update_action.rs`, `updates.rs`, `update_prompt.rs`):**
+
+Compiled only when `upstream-updates` feature is disabled. Provides Nori-specific update checking:
+
+`update_action.rs`:
+- `UpdateAction` enum with `NpmGlobalLatest` and `Manual` variants
+- `command_args()` returns the shell command to execute the update
+- `get_update_action()` (release builds only) checks `NORI_MANAGED_BY_NPM` env var to determine update method
+
+`updates.rs` (release builds only):
+- Queries `https://api.github.com/repos/tilework-tech/nori-cli/releases/latest` for version info
+- Caches version data in `~/.codex/nori-version.json` with 20-hour refresh interval
+- `get_upgrade_version()`: Background-refreshes cache and returns newer version if available
+- `get_upgrade_version_for_popup()`: Returns version only if not previously dismissed
+- `dismiss_version()`: Persists user's dismissal to avoid repeated prompts
+- Tag format: expects `nori-v<semver>` (e.g., `nori-v1.2.3`)
+
+`update_prompt.rs` (release builds only):
+- `run_update_prompt_if_needed()`: Displays update prompt UI when new version available
+- Returns `UpdatePromptOutcome::Continue` or `UpdatePromptOutcome::RunUpdate(action)`
+
 ### Things to Know
 
 **Profile Display:**
@@ -70,4 +99,17 @@ The original Codex session header (`SessionHeaderHistoryCell`) is preserved with
 
 The session header uses a max inner width of 60 characters. Directory paths are center-truncated when they exceed available space (e.g., `~/a/b/…/y/z`).
 
+**Conditional Compilation:**
+
+Module availability in `mod.rs` follows this pattern:
+
+```
+session_header.rs, agent_picker.rs  -> Always included
+feedback.rs                         -> #[cfg(not(feature = "feedback"))]
+update_action.rs                    -> #[cfg(not(feature = "upstream-updates"))]
+update_prompt.rs, updates.rs        -> #[cfg(all(not(feature = "upstream-updates"), not(debug_assertions)))]
+```
+
+The `lib.rs` re-export logic ensures `UpdateAction` type is always available via `codex_tui::update_action::UpdateAction` regardless of which update system is compiled.
+
 Created and maintained by Nori.

codex-rs/tui/src/nori/mod.rs

@@ -8,3 +8,12 @@ pub(crate) mod session_header;
 
 #[cfg(not(feature = "feedback"))]
 pub(crate) mod feedback;
+
+// update_action is available in all builds for the UpdateAction type
+// update_prompt and updates are only for release builds
+#[cfg(not(feature = "upstream-updates"))]
+pub(crate) mod update_action;
+#[cfg(all(not(feature = "upstream-updates"), not(debug_assertions)))]
+pub(crate) mod update_prompt;
+#[cfg(all(not(feature = "upstream-updates"), not(debug_assertions)))]
+pub(crate) mod updates;

codex-rs/tui/src/nori/update_action.rs

@@ -29,6 +29,11 @@ impl UpdateAction {
     }
 }
 
+/// Returns the update action for the current installation.
+///
+/// Unlike the upstream version which returns `None` for unknown installations,
+/// this always returns `Some()` because Nori supports a manual update fallback
+/// that directs users to GitHub releases.
 #[cfg(not(debug_assertions))]
 pub(crate) fn get_update_action() -> Option<UpdateAction> {
     let managed_by_npm = std::env::var_os("NORI_MANAGED_BY_NPM").is_some();