Commit 2d4d34a
fix(acp): re-apply Claude ACP adapter upgrade to @agentclientprotocol scope (#449)
## Summary
🤖 Generated with [Nori](https://www.npmjs.com/package/nori-ai)
- Re-applies the Claude ACP adapter package rename from
`@zed-industries/claude-agent-acp` (frozen at 0.23.1) to
`@agentclientprotocol/claude-agent-acp` (active, latest 0.30.0)
- The original upgrade (PR #447) was reverted in PR #448 due to a
"Failed to create ACP session" error
- Root cause investigation showed the error was transient — the new
adapter v0.30.0 is fully protocol-compatible with our
`agent-client-protocol-schema v0.11.6`
## Investigation Details
The "Failed to create ACP session" error was traced through the full
error chain (`sacp_connection.rs:507` → `spawn_and_relay.rs:59-78` →
`agent.rs:273`). Manual protocol testing with v0.30.0 confirmed:
- `initialize` handshake succeeds (protocol version V1 negotiation)
- `session/new` request succeeds (schema fields `cwd` and `mcpServers`
are correct)
- `NewSessionResponse` deserializes correctly despite new fields
(`modes`, `configOptions`)
End-to-end TUI verification with `NORI_MANAGED_BY_NPM=1` (to force npx
and the real v0.30.0 adapter) confirmed full round-trip: spawn →
handshake → session → prompt → response.
## Test Plan
- [x] `test_get_claude_code_config` verifies the built-in Claude config
uses the new package name
- [x] All 443 passing ACP crate tests still pass (14 pre-existing
failures in `backend::tests::part3` are unrelated — they require a mock
ACP binary)
- [x] End-to-end TUI verification: built nori binary, launched via tmux
with real Claude adapter v0.30.0, sent a message and received a response
- [x] Clippy clean
Share Nori with your team: https://www.npmjs.com/package/nori-skillsets
---------
Co-authored-by: Nori <contact@tilework.tech>1 parent 5a5eba2 commit 2d4d34a
3 files changed
Lines changed: 29 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1023 | 1023 | | |
1024 | 1024 | | |
1025 | 1025 | | |
1026 | | - | |
| 1026 | + | |
1027 | 1027 | | |
1028 | 1028 | | |
1029 | 1029 | | |
| |||
1033 | 1033 | | |
1034 | 1034 | | |
1035 | 1035 | | |
1036 | | - | |
| 1036 | + | |
1037 | 1037 | | |
1038 | 1038 | | |
1039 | 1039 | | |
| |||
1130 | 1130 | | |
1131 | 1131 | | |
1132 | 1132 | | |
1133 | | - | |
| 1133 | + | |
1134 | 1134 | | |
1135 | 1135 | | |
1136 | 1136 | | |
| |||
1217 | 1217 | | |
1218 | 1218 | | |
1219 | 1219 | | |
1220 | | - | |
| 1220 | + | |
1221 | 1221 | | |
1222 | 1222 | | |
1223 | 1223 | | |
1224 | 1224 | | |
1225 | 1225 | | |
1226 | 1226 | | |
1227 | 1227 | | |
1228 | | - | |
| 1228 | + | |
1229 | 1229 | | |
1230 | 1230 | | |
1231 | 1231 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
101 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
102 | 104 | | |
103 | 105 | | |
104 | 106 | | |
| |||
703 | 705 | | |
704 | 706 | | |
705 | 707 | | |
706 | | - | |
| 708 | + | |
707 | 709 | | |
708 | 710 | | |
709 | 711 | | |
| |||
718 | 720 | | |
719 | 721 | | |
720 | 722 | | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
721 | 739 | | |
722 | 740 | | |
723 | 741 | | |
724 | 742 | | |
725 | 743 | | |
726 | | - | |
| 744 | + | |
727 | 745 | | |
728 | 746 | | |
729 | 747 | | |
| |||
999 | 1017 | | |
1000 | 1018 | | |
1001 | 1019 | | |
1002 | | - | |
1003 | 1020 | | |
1004 | 1021 | | |
1005 | 1022 | | |
1006 | | - | |
| 1023 | + | |
1007 | 1024 | | |
1008 | 1025 | | |
1009 | 1026 | | |
| |||
0 commit comments