Skip to content

Commit ccd950a

Browse files
committed
Remove unused changes from upstream main
1 parent 2107f9e commit ccd950a

3 files changed

Lines changed: 7 additions & 11 deletions

File tree

codex-rs/core/src/config/mod.rs

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1061,17 +1061,10 @@ impl Config {
10611061
model_providers.entry(key).or_insert(provider);
10621062
}
10631063

1064-
// Determine model early so we can infer provider if needed
1065-
let model = model
1066-
.or(config_profile.model.clone())
1067-
.or(cfg.model.clone())
1068-
.unwrap_or_else(default_model);
1069-
10701064
let model_provider_id = model_provider
10711065
.or(config_profile.model_provider)
10721066
.or(cfg.model_provider)
10731067
.unwrap_or_else(|| "openai".to_string());
1074-
10751068
let model_provider = model_providers
10761069
.get(&model_provider_id)
10771070
.ok_or_else(|| {
@@ -1105,7 +1098,11 @@ impl Config {
11051098

11061099
let forced_login_method = cfg.forced_login_method;
11071100

1108-
// Model was already determined above for provider inference
1101+
let model = model
1102+
.or(config_profile.model)
1103+
.or(cfg.model)
1104+
.unwrap_or_else(default_model);
1105+
11091106
let mut model_family =
11101107
find_family_for_model(&model).unwrap_or_else(|| derive_default_model_family(&model));
11111108

codex-rs/core/src/model_family.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
use codex_protocol::config_types::ReasoningEffort;
22
use codex_protocol::config_types::Verbosity;
33

4+
use crate::CLAUDE_ACP_PROVIDER_ID;
45
use crate::GEMINI_ACP_PROVIDER_ID;
6+
use crate::MOCK_ACP_PROVIDER_ID;
57
use crate::config::types::ReasoningSummaryFormat;
6-
use crate::model_provider_info::CLAUDE_ACP_PROVIDER_ID;
7-
use crate::model_provider_info::MOCK_ACP_PROVIDER_ID;
88
use crate::tools::handlers::apply_patch::ApplyPatchToolType;
99
use crate::tools::spec::ConfigShellToolType;
1010

codex-rs/core/src/model_provider_info.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,6 @@ pub const DEFAULT_OLLAMA_PORT: u16 = 11434;
309309

310310
pub const LMSTUDIO_OSS_PROVIDER_ID: &str = "lmstudio";
311311
pub const OLLAMA_OSS_PROVIDER_ID: &str = "ollama";
312-
pub const BUILT_IN_OSS_MODEL_PROVIDER_ID: &str = "oss";
313312

314313
// ACP provider identifiers (used for model inference, not in built_in_model_providers)
315314
// Actual ACP provider configuration is embedded in AcpAgentConfig from codex_acp::registry

0 commit comments

Comments
 (0)