fix(acp): re-apply Claude ACP adapter upgrade to @agentclientprotocol scope#449
Merged
fix(acp): re-apply Claude ACP adapter upgrade to @agentclientprotocol scope#449
Conversation
…scope The original upgrade (PR #447) was reverted in PR #448 due to a "Failed to create ACP session" error. Investigation showed the error was transient — the new adapter v0.30.0 is fully protocol-compatible with our schema v0.11.6. End-to-end verification via tmux confirmed spawn, handshake, session creation, prompt submission, and response all work correctly with @agentclientprotocol/claude-agent-acp@0.30.0. The old package @zed-industries/claude-agent-acp is frozen at 0.23.1 and deprecated. 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
The v0.30.0 adapter resolves its native binary via require.resolve() on platform-specific optional deps. On Linux it tries the musl variant first; if that file exists but the musl loader is missing, the binary silently fails to execute, causing "Failed to create ACP session". Setting CLAUDE_CODE_EXECUTABLE to the system-installed claude binary sidesteps this entirely. Also adds @latest suffix to the package name to force bunx to resolve the correct scope instead of a stale @zed-industries cache entry. 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
@zed-industries/claude-agent-acp(frozen at 0.23.1) to@agentclientprotocol/claude-agent-acp(active, latest 0.30.0)agent-client-protocol-schema v0.11.6Investigation Details
The "Failed to create ACP session" error was traced through the full error chain (
sacp_connection.rs:507→spawn_and_relay.rs:59-78→agent.rs:273). Manual protocol testing with v0.30.0 confirmed:initializehandshake succeeds (protocol version V1 negotiation)session/newrequest succeeds (schema fieldscwdandmcpServersare correct)NewSessionResponsedeserializes correctly despite new fields (modes,configOptions)End-to-end TUI verification with
NORI_MANAGED_BY_NPM=1(to force npx and the real v0.30.0 adapter) confirmed full round-trip: spawn → handshake → session → prompt → response.Test Plan
test_get_claude_code_configverifies the built-in Claude config uses the new package namebackend::tests::part3are unrelated — they require a mock ACP binary)Share Nori with your team: https://www.npmjs.com/package/nori-skillsets