fix(config): Add config toggle for working messages#464
Merged
Conversation
6 tasks
CSRessel
added a commit
that referenced
this pull request
May 8, 2026
## Summary 🤖 Generated with [Nori](https://noriagentic.com/) - Adds `[tui].custom_working_message_list` to home Nori config so users can supply their own array of working messages, overriding the builtin whimsical pool while keeping the existing `custom_working_messages` on/off toggle from #464. - Consolidates status-header selection through a single `pick_status_message(bool, &[String])` helper, fixing a regression where `on_task_started` ignored the toggle for any task after the first. - `/config` menu still only edits the boolean; the user list is TOML-only. The menu entry's description now advertises when a custom list is active so toggling does not surprise the user. ## Behavior - `custom_working_messages = false` → plain `Working` (existing). - `custom_working_messages = true` (default), no list → builtin whimsical rotation (existing). - `custom_working_messages = true`, `custom_working_message_list = ["foo", "bar"]` → samples from user list (new). - `custom_working_messages = false`, list set → still plain `Working` (bool wins). ## Test Plan - [x] `cargo test -p codex-core --lib custom_working_message` (5 passed) - [x] `cargo test -p nori-acp --lib test_nori_config` (7 passed) - [x] All 1219 nori-tui lib tests pass; new tests for widget, on_task_started bug fix, and picker description verified GREEN. - [x] `just fix -p codex-core -p nori-acp -p nori-tui` clean. - [x] `cargo fmt`. - [ ] Reviewer: confirm `cargo build --bin nori` and `cargo test -p tui-pty-e2e` pass in CI. Share Nori with your team: https://www.npmjs.com/package/nori-skillsets Co-authored-by: Cliff <clifford@tilework.tech> Co-authored-by: Nori <contact@tilework.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan