Skip to content

fix(config): Add config toggle for working messages#464

Merged
CSRessel merged 2 commits intomainfrom
config-disable-working-messages
May 7, 2026
Merged

fix(config): Add config toggle for working messages#464
CSRessel merged 2 commits intomainfrom
config-disable-working-messages

Conversation

@nori-sessions
Copy link
Copy Markdown
Contributor

@nori-sessions nori-sessions Bot commented May 5, 2026

Summary

  • Add tui.custom_working_messages config, defaulting to true, with TOML parsing in core and ACP config loaders.
  • Add a /config toggle that persists the setting and updates the active status indicator.
  • Use plain Working status text when custom working messages are disabled, and document the setting.

Test Plan

  • cargo test -p codex-core --lib tui_config_custom_working_messages
  • cargo test -p nori-acp test_nori_config --lib
  • cargo test -p nori-tui custom_working_messages --lib
  • cargo clippy -p codex-core -p nori-acp -p nori-tui --lib --all-targets
  • cargo build --bin nori
  • cargo build -p mock-acp-agent
  • cargo test -p tui-pty-e2e
  • cargo fmt
  • git diff --check

@CSRessel CSRessel changed the title Add config toggle for working messages fix(config): Add config toggle for working messages May 7, 2026
@CSRessel CSRessel marked this pull request as ready for review May 7, 2026 15:39
@CSRessel CSRessel merged commit 0299264 into main May 7, 2026
3 checks passed
@CSRessel CSRessel deleted the config-disable-working-messages branch May 7, 2026 18:16
CSRessel added a commit that referenced this pull request May 8, 2026
## Summary
🤖 Generated with [Nori](https://noriagentic.com/)

- Adds `[tui].custom_working_message_list` to home Nori config so users
can supply their own array of working messages, overriding the builtin
whimsical pool while keeping the existing `custom_working_messages`
on/off toggle from #464.
- Consolidates status-header selection through a single
`pick_status_message(bool, &[String])` helper, fixing a regression where
`on_task_started` ignored the toggle for any task after the first.
- `/config` menu still only edits the boolean; the user list is
TOML-only. The menu entry's description now advertises when a custom
list is active so toggling does not surprise the user.

## Behavior
- `custom_working_messages = false` → plain `Working` (existing).
- `custom_working_messages = true` (default), no list → builtin
whimsical rotation (existing).
- `custom_working_messages = true`, `custom_working_message_list =
["foo", "bar"]` → samples from user list (new).
- `custom_working_messages = false`, list set → still plain `Working`
(bool wins).

## Test Plan
- [x] `cargo test -p codex-core --lib custom_working_message` (5 passed)
- [x] `cargo test -p nori-acp --lib test_nori_config` (7 passed)
- [x] All 1219 nori-tui lib tests pass; new tests for widget,
on_task_started bug fix, and picker description verified GREEN.
- [x] `just fix -p codex-core -p nori-acp -p nori-tui` clean.
- [x] `cargo fmt`.
- [ ] Reviewer: confirm `cargo build --bin nori` and `cargo test -p
tui-pty-e2e` pass in CI.

Share Nori with your team: https://www.npmjs.com/package/nori-skillsets

Co-authored-by: Cliff <clifford@tilework.tech>
Co-authored-by: Nori <contact@tilework.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant