feat(config): User-defined working messages list#466
Merged
Conversation
Adds `[tui].custom_working_message_list` (Vec<String>) to nori config so users can override the builtin whimsical "working" status messages with their own list. The existing `custom_working_messages` boolean still gates rotation on/off; when on and the user list is non-empty the TUI samples from the user's strings instead of the builtin pool. While here, fix a regression of #464 where on_task_started always called random_status_message() unconditionally, defeating the boolean toggle for any task after the first. All status-header selection now routes through a single pick_status_message(bool, &[String]) helper. The /config menu only edits the boolean; the user list is TOML-only. The "Custom Working Messages" menu entry's description announces when a custom list is active so toggling the boolean doesn't surprise users. 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
[tui].custom_working_message_listto home Nori config so users can supply their own array of working messages, overriding the builtin whimsical pool while keeping the existingcustom_working_messageson/off toggle from fix(config): Add config toggle for working messages #464.pick_status_message(bool, &[String])helper, fixing a regression whereon_task_startedignored the toggle for any task after the first./configmenu still only edits the boolean; the user list is TOML-only. The menu entry's description now advertises when a custom list is active so toggling does not surprise the user.Behavior
custom_working_messages = false→ plainWorking(existing).custom_working_messages = true(default), no list → builtin whimsical rotation (existing).custom_working_messages = true,custom_working_message_list = ["foo", "bar"]→ samples from user list (new).custom_working_messages = false, list set → still plainWorking(bool wins).Test Plan
cargo test -p codex-core --lib custom_working_message(5 passed)cargo test -p nori-acp --lib test_nori_config(7 passed)just fix -p codex-core -p nori-acp -p nori-tuiclean.cargo fmt.cargo build --bin noriandcargo test -p tui-pty-e2epass in CI.Share Nori with your team: https://www.npmjs.com/package/nori-skillsets