feat: Implement ACP inline streaming with word wrapping#48
Merged
Conversation
This commit introduces a new inline streaming system for ACP agents that displays assistant messages incrementally with proper word wrapping before committing them to the scrollback buffer. Key changes: - Add BackendEvent enum to wrap ConversationEvent and inline events - Implement InlineEntryState for tracking streaming text with wrapping - Add text_utils module with wrap_text_to_width function - Update all backends to emit BackendEvent instead of ConversationEvent - Track inline entries in Model and render them in UI - Update tests to handle new BackendEvent structure Benefits: - Assistant messages now appear immediately as they stream - Proper word wrapping adapts to terminal width changes - Cleaner separation between streaming and committed content 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- handle AgentThoughtChunk updates and emit thinking entries - track separate assistant/thinking buffers with commit/abort-all helpers - adjust history types and inline tracker test coverage
Collaborator
Author
|
First time I used an agent via the nori CLI for something useful! (after doing the work elsewhere, asked it to create this commit and github PR) 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new inline streaming system for ACP agents that displays assistant messages incrementally with proper word wrapping before committing them to the scrollback buffer.
Key Changes
ConversationEventand adds inline events (InlineBegin,InlineUpdate,InlineCommit,InlineAbort)src/history.rstext_utilsmodule withwrap_text_to_widthfunction for proper text reflowBackendEventinstead ofConversationEventBackendEventstructure with inline event trackingBenefits
✨ Assistant messages appear immediately as they stream
📐 Proper word wrapping adapts to terminal width changes
🎯 Cleaner separation between streaming and committed content
🧪 All tests passing with comprehensive inline event handling
Test Plan
acp_runner_test.rs🤖 Generated with Claude Code