feat(acp): Add approval bridging infrastructure#62
Merged
Conversation
Implements the minimal-footprint approval bridging between ACP permission requests and Codex approval system: - Add ApprovalRequest type bundling translated event with response channel - Translate ACP RequestPermissionRequest to Codex ExecApprovalRequestEvent - Translate Codex ReviewDecision back to ACP RequestPermissionOutcome - Expose approval receiver via AcpConnection::take_approval_receiver() - Fall back to auto-approve if channel closed, deny if response dropped - Add placeholder comments for future: history persistence, export, resume This enables the TUI to receive approval requests and respond to them without modifying codex-core.
CSRessel
force-pushed
the
feat-acp-minimal-footprint
branch
from
1fb6cfc to
f41389e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
ApprovalRequesttype and translation functions for bi-directional conversionAcpConnection::take_approval_receiver()for TUI integrationTest Plan
Share Nori with your team: https://www.npmjs.com/package/nori-ai