fix(acp): Complete approval bridging for ACP mode#70
Merged
Conversation
Fix approval popup not appearing when ACP agents request permission. The root cause was that approval requests were being deferred during active streaming, but in ACP mode the agent subprocess blocks waiting for approval - causing a deadlock. Changes: - Handle approval requests immediately in TUI (not deferred) - Add MOCK_AGENT_REQUEST_PERMISSION support to mock agent - Enable test_acp_approval_request_displayed_in_tui test - Update documentation for approval handling behavior
CSRessel
force-pushed
the
acp-backend-completion
branch
from
da2f877 to
2fc90ed
Compare
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
MOCK_AGENT_REQUEST_PERMISSIONsupport to mock agent for testingtest_acp_approval_request_displayed_in_tuiE2E testTest Plan
Share Nori with your team: https://www.npmjs.com/package/nori-ai