fix(ci): Resolve macOS test failures on GitHub runners#81
Merged
CSRessel merged 4 commits intoDec 6, 2025
Conversation
The mock_acp_agent path resolution only went up one parent directory,
which resolved to target/{arch}/{profile}/deps/mock_acp_agent instead
of target/{arch}/{profile}/mock_acp_agent where the binary is actually
placed.
Changed to use .parent().and_then(|p| p.parent()) to correctly navigate
from deps/ to the profile directory, matching the pattern used by
codex_binary_path() in tui-pty-e2e.
The mock_acp_agent path resolution now detects the execution context: - When running as `codex` binary: parent dir is the profile dir - When running as test binary: parent dir is `deps/`, need two levels up This fixes cross-platform compatibility where Linux runs codex binary directly while macOS tests may run from the deps/ directory context.
The mock_acp_agent binary location varies across platforms due to different cargo target directory structures. This fix: 1. Adds a CI step to build mock-acp-agent with --artifact-dir to place the binary in a predictable location (target/mock-acp-out/) 2. Sets MOCK_ACP_AGENT_BIN environment variable pointing to the binary 3. Updates registry.rs to check MOCK_ACP_AGENT_BIN first, falling back to relative path resolution for local development This ensures consistent mock agent discovery on both Linux and macOS CI.
Collaborator
Author
|
This fixes the location of the build target, but looks like there's some other issue on MacOS that has been uncovered. Saving that for a separate PR |
CSRessel
deleted the
claude/fix-macos-test-failures-016AoBKUsLfap411HWMew3AZ
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mock_acp_agent path resolution only went up one parent directory, which resolved to target/{arch}/{profile}/deps/mock_acp_agent instead of target/{arch}/{profile}/mock_acp_agent where the binary is actually placed.
Changed to use .parent().and_then(|p| p.parent()) to correctly navigate from deps/ to the profile directory, matching the pattern used by codex_binary_path() in tui-pty-e2e.